Fix Font constructor compatibility with Majorsilence.Drawing wrapper#248
Draft
Fix Font constructor compatibility with Majorsilence.Drawing wrapper#248
Conversation
…ability Co-authored-by: majorsilence <656288+majorsilence@users.noreply.github.com>
Copilot
AI
changed the title
[WIP] Fix issues with EAN 13 barcode readability
Fix EAN-13 barcode rendering quality for better scanning and readability
Oct 19, 2025
Co-authored-by: majorsilence <656288+majorsilence@users.noreply.github.com>
Copilot
AI
changed the title
Fix EAN-13 barcode rendering quality for better scanning and readability
Fix Font constructor compatibility with Majorsilence.Drawing wrapper
Feb 24, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The EAN-13 barcode improvements introduced a Font constructor call incompatible with the
Majorsilence.Drawing.Fontwrapper used in DRAWINGCOMPAT builds.Changes
GraphicsUnit.Pixelparameter from Font constructorThe
Majorsilence.Drawing.Fontwrapper (SkiaSharp-based) only provides:Font(string familyName, float size)Font(string familyName, float size, FontStyle style)Unlike
System.Drawing.Font, it lacks theGraphicsUnitoverload. SincefontHeightPixelsis already in pixel units, the unit specification was redundant.Original prompt
Fixes #182
💡 You can make Copilot smarter by setting up custom instructions, customizing its development environment and configuring Model Context Protocol (MCP) servers. Learn more Copilot coding agent tips in the docs.