Fix unicode escape decode #77
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This code:
chr $u =~ /[[:^ascii:]]/
… processes the pattern-match first, then the chr. That means that
the overall result will either be "\0" or "\1", both of which Perl
regards as truthy. Thus, the “optimized” path never happens.
(This can be confirmed by putting a die() in the optimized path.)
This fixes that by using the $hex value computed just above.
FGasper
force-pushed
the
fix_unicode_escape_decode
branch
2 times, most recently
from
4f46cb3 to
4db1f9b
Compare
Collaborator
|
@FGasper Thanks for the PR. The change is from https://github.com/makamaka/JSON-PP/pull/64/files#diff-8eae66db42fb29ffa131a180d7e8c9b771d4717c9877ba1fda72cfd3d923afbfL607-R620 . Unfortunately I am not accessible to an EBCDIC environment. Could you communicate with khwilliamson first to find what's the best way for both? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.