test: increase unit test coverage (cloud, cover, remote, datetime, config_flow, entity)#5304
Merged
make-all merged 3 commits intoJun 14, 2026
Merged
Conversation
…ig_flow, entity Adds unit tests for Python code (no production changes), per the 'complete the remaining unit tests' item in the README. Coverage across these modules rises from 43% to 94%: - cloud.py 25% -> 99% - cover.py 34% -> 98% - remote.py 31% -> 93% - datetime.py 31% -> 88% - config_flow.py 53% -> 91% - entity.py 85% -> 94% Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
make-all
requested changes
Jun 13, 2026
Owner
There was a problem hiding this comment.
These tests should be merged into test_config_flow.py rather than adding a new file.
Owner
There was a problem hiding this comment.
These files should be merged to the existing entity test files.
Fold the new cover/datetime/remote/config_flow tests into their existing per-module test files and remove the parallel *_unit/_extended files, per maintainer review. test_entity.py and test_cloud.py are kept as new files since entity.py and cloud.py had no existing test file to merge into. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
Contributor
Author
|
Thanks for the review. I've merged the new tests into the existing per-module files and removed the parallel files:
Two remain as new files — Full suite passes (379 tests) and |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds unit tests for existing Python code — no production changes. This is the "complete the remaining unit tests" item from the README's Contributing section.
Coverage across the six modules goes from 43% → 94% (502 lines newly covered):
test_config_flow_extended.pycomplements the existingtest_config_flow.py(cloud/scan/search/connection paths). All 379 suite tests pass;ruff check,ruff format --checkand the existing tests are clean.🤖 Generated with Claude Code