Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[WEB-2433] chore-Update name of the Layout #5661

Open
wants to merge 2 commits into
base: preview
Choose a base branch
from

Conversation

Jimmycutie
Copy link
Collaborator

@Jimmycutie Jimmycutie commented Sep 19, 2024

Clean Reason

Changed layout names to simpler keywords to improve user experience.

Implementation

Changed kanban to board, gantt to timeline, spreadsheet to table and grid to gallery.

Screenshot 2024-09-19 190400
Screenshot 2024-09-19 190405
Screenshot 2024-09-19 190411
Screenshot 2024-09-19 190951
Screenshot 2024-09-19 191049

References

[WEB-2433]

Summary by CodeRabbit

  • New Features
    • Updated layout titles for improved clarity:
      • "Kanban" to "Board"
      • "Grid layout" to "Gallery layout"
      • "Gantt layout" to "Timeline layout"
      • "List Layout" to "List layout"
      • "Spreadsheet Layout" to "Table layout"
      • "Calendar Layout" to "Calendar layout."
  • Bug Fixes
    • None reported.
  • Documentation
    • Terminology enhancements to align with user understanding.

@Jimmycutie Jimmycutie added 🌟enhancement New feature or request 🌐frontend 🌐web Issues related to our web product 🧹chore labels Sep 19, 2024
@Jimmycutie Jimmycutie added this to the v0.23-dev milestone Sep 19, 2024
Copy link
Contributor

coderabbitai bot commented Sep 19, 2024

Walkthrough

The changes involve updating the titles of various layout options across multiple components and constants in the codebase. Specifically, the term "Kanban" has been replaced with "Board," and other layout titles have been modified for clarity, such as changing "Grid layout" to "Gallery layout" and "Gantt layout" to "Timeline layout." These adjustments aim to enhance the user interface terminology without altering the underlying functionality of the components.

Changes

File Path Change Summary
web/app/[workspaceSlug]/(projects)/projects/(detail)/[projectId]/cycles/(detail)/mobile-header.tsx
web/app/[workspaceSlug]/(projects)/projects/(detail)/[projectId]/issues/(list)/mobile-header.tsx
web/app/[workspaceSlug]/(projects)/projects/(detail)/[projectId]/modules/(detail)/mobile-header.tsx
Renamed layout title from "Kanban" to "Board" in multiple mobile header components.
web/core/constants/cycle.ts Renamed layout titles: "Grid layout" to "Gallery layout" and "Gantt layout" to "Timeline layout."
web/core/constants/issue.ts Renamed layout titles and labels: "Kanban Layout" to "Board Layout," "Spreadsheet Layout" to "Table Layout," and "Gantt Chart Layout" to "Timeline Layout."
web/core/constants/module.ts Renamed layout titles: "Grid layout" to "Gallery layout" and "Gantt layout" to "Timeline layout."

Possibly related PRs

Suggested labels

🎨UI / UX

Suggested reviewers

  • SatishGandham
  • sriramveeraghanta
  • rahulramesha

🐇 In the meadow, changes bloom,
Titles shift, dispelling gloom.
"Board" now reigns where "Kanban" lay,
Clarity brightens the user’s day.
With "Gallery" and "Timeline" in sight,
Our UI shines, oh what a delight! 🌼


Recent review details

Configuration used: CodeRabbit UI
Review profile: CHILL

Commits

Files that changed from the base of the PR and between 5f50d3d and c6224e9.

Files selected for processing (1)
  • web/core/constants/issue.ts (1 hunks)
Files skipped from review as they are similar to previous changes (1)
  • web/core/constants/issue.ts

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

Share
Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    -- I pushed a fix in commit <commit_id>, please review it.
    -- Generate unit testing code for this file.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    -- @coderabbitai generate unit testing code for this file.
    -- @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    -- @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
    -- @coderabbitai read src/utils.ts and generate unit testing code.
    -- @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    -- @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Other keywords and placeholders

  • Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
  • Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
  • Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

@aaryan610 aaryan610 self-requested a review September 23, 2024 07:32
@@ -157,7 +157,7 @@ export const ISSUE_EXTRA_OPTIONS: {

export const ISSUE_LAYOUT_MAP = {
[EIssueLayoutTypes.LIST]: { key: EIssueLayoutTypes.LIST, title: "List Layout", label: "List", icon: List },
[EIssueLayoutTypes.KANBAN]: { key: EIssueLayoutTypes.KANBAN, title: "Kanban Layout", label: "Kanban", icon: Kanban },
[EIssueLayoutTypes.KANBAN]: { key: EIssueLayoutTypes.KANBAN, title: "Board Layout", label: "Board", icon: Kanban },
Copy link
Collaborator

@aaryan610 aaryan610 Sep 23, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Change the casing of layout from Layout to layout across this file

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done

Copy link
Collaborator

@anmolsinghbhatia anmolsinghbhatia left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you also update the file and folder names?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🧹chore 🌟enhancement New feature or request 🌐frontend 🌐web Issues related to our web product
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants