Update login.py

[codecloudsintern]

Summary by CodeRabbit

• Bug Fixes

  • Improved session expiry handling for admin users.

• Refactor

  • Enhanced code readability and formatting in the user login functionality.

[CLAassistant]

All committers have signed the CLA.

[coderabbitai]

Walkthrough

The changes involve modifications to the user_login function in the apiserver/plane/authentication/utils/login.py file. The function's formatting has been improved for better readability, with adjustments made to spacing and indentation. A specific line regarding session expiry for admin users has been adjusted for consistency in formatting. The overall logic of the function remains unchanged, but the final return statement has been removed.

Changes

Files	Change Summary
apiserver/plane/authentication/utils/login.py	Reformatted user_login function; adjusted session expiry setting; improved readability; removed final return statement.

Poem

In the code where rabbits hop,
A login fix, we won't stop!
With spaces neat and settings bright,
Admin sessions now take flight.
Hooray for changes, let’s all cheer,
For cleaner code, we hold so dear! 🐇✨

---

📜 Recent review details

Configuration used: CodeRabbit UI
Review profile: CHILL

📥 Commits

Files that changed from the base of the PR and between e922d5d and 00e41ad.

📒 Files selected for processing (1)

• apiserver/plane/authentication/utils/login.py (1 hunks)

🚧 Files skipped from review as they are similar to previous changes (1)

• apiserver/plane/authentication/utils/login.py

---

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

• Review comments: Directly reply to a review comment made by CodeRabbit. Example:
  • I pushed a fix in commit <commit_id>, please review it.
  • Generate unit testing code for this file.
  • Open a follow-up GitHub issue for this discussion.
• Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
  • @coderabbitai generate unit testing code for this file.
  • @coderabbitai modularize this function.
• PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
  • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
  • @coderabbitai read src/utils.ts and generate unit testing code.
  • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
  • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

• @coderabbitai pause to pause the reviews on a PR.
• @coderabbitai resume to resume the paused reviews.
• @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
• @coderabbitai full review to do a full review from scratch and review all the files again.
• @coderabbitai summary to regenerate the summary of the PR.
• @coderabbitai resolve resolve all the CodeRabbit review comments.
• @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
• @coderabbitai help to get help.

Other keywords and placeholders

• Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
• Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
• Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

• You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
• Please see the configuration documentation for more information.
• If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

• Visit our Documentation for detailed information on how to use CodeRabbit.
• Join our Discord Community to get help, request features, and share feedback.
• Follow us on X/Twitter for updates and announcements.

[coderabbitai]

Actionable comments posted: 1

📜 Review details

Configuration used: CodeRabbit UI
Review profile: CHILL

📥 Commits

Files that changed from the base of the PR and between ec08fb0 and e922d5d.

📒 Files selected for processing (1)

• apiserver/plane/authentication/utils/login.py (1 hunks)

🔇 Additional comments (3)

apiserver/plane/authentication/utils/login.py (3)

1-8: LGTM! Import statements and function signature look good.

The changes improve readability by separating imports onto individual lines and grouping them according to PEP 8 guidelines. The function signature remains unchanged, which is consistent with the summary.

---

15-24: LGTM! Improved formatting of the device_info dictionary.

The reformatting of the device_info dictionary construction improves readability. The multi-line formatting of the base_host function call is consistent with PEP 8 guidelines for line length. The logic and content remain unchanged, which is good.

---

24-28: Verify changes in function behavior and clean up formatting.

1. The device_info assignment to the session has been moved outside the if is_admin: block. This changes the function's behavior as it will now always set the device_info regardless of whether the user is an admin. Please confirm if this is intentional.

2. There are multiple unnecessary empty lines at the end of the function. These should be removed to comply with PEP 8 guidelines.

3. The final return statement seems to have been removed. If the function is not meant to return anything, this is fine, but please confirm that this was intentional.

Could you please clarify these changes and make the necessary adjustments? Here's a suggested cleanup for the end of the function:

         ),
     }
-    request.session["device_info"] = device_info
- 
-   
-    
+    request.session["device_info"] = device_info

If the device_info assignment should only happen for admin users, please move it back inside the if is_admin: block.