Update login.py

[codecloudsintern]

Summary by CodeRabbit

• Refactor
  • Improved the readability of the user login functionality through formatting adjustments.
  • Maintained existing logic and functionality, ensuring consistent session management and device information handling.

[CLAassistant]

All committers have signed the CLA.

[coderabbitai]

Walkthrough

The changes involve modifications to the user_login function in the apiserver/plane/authentication/utils/login.py file. The adjustments primarily focus on reformatting the code for improved clarity, specifically in terms of whitespace and indentation, while maintaining the original logic and functionality. The method signature and core operations, including session management and device information handling, remain unchanged.

Changes

Files	Change Summary
apiserver/plane/authentication/utils/login.py	Reformatted user_login function for improved clarity; whitespace and indentation adjustments made without altering logic or functionality.

Poem

In the code where rabbits play,
Whitespace dances, brightening the day.
With each line, clarity blooms,
As logic hums in cozy rooms.
A login function, neat and spry,
Hops along, reaching for the sky! 🐇✨

---

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

• Review comments: Directly reply to a review comment made by CodeRabbit. Example:
  • I pushed a fix in commit <commit_id>, please review it.
  • Generate unit testing code for this file.
  • Open a follow-up GitHub issue for this discussion.
• Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
  • @coderabbitai generate unit testing code for this file.
  • @coderabbitai modularize this function.
• PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
  • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
  • @coderabbitai read src/utils.ts and generate unit testing code.
  • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
  • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

• @coderabbitai pause to pause the reviews on a PR.
• @coderabbitai resume to resume the paused reviews.
• @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
• @coderabbitai full review to do a full review from scratch and review all the files again.
• @coderabbitai summary to regenerate the summary of the PR.
• @coderabbitai resolve resolve all the CodeRabbit review comments.
• @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
• @coderabbitai help to get help.

Other keywords and placeholders

• Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
• Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
• Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

• You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
• Please see the configuration documentation for more information.
• If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

• Visit our Documentation for detailed information on how to use CodeRabbit.
• Join our Discord Community to get help, request features, and share feedback.
• Follow us on X/Twitter for updates and announcements.

[coderabbitai]

Actionable comments posted: 0

🧹 Outside diff range and nitpick comments (1)

apiserver/plane/authentication/utils/login.py (1)

1-28: Improve code formatting and remove unnecessary whitespace

While the changes don't introduce any functional issues, there are some formatting inconsistencies and unnecessary whitespace. Consider the following improvements:

1. Remove unnecessary empty lines (lines 4, 14, 26-28).
2. Standardize indentation throughout the file. The device_info dictionary (lines 15-24) uses a different indentation style compared to the rest of the file.
3. Ensure consistent spacing around operators and after commas.

Here's a suggested diff to address these issues:

 #Django imports
 from django.contrib.auth import login 
 from django.conf import settings 
-
 from plane.authentication.utils.host import base_host 
- # Module imports

 def user_login(request, user, is_app=False, is_admin=False, is_space=False): 
     login(request, user) 

-# If is admin cookie set the custom age
+    # If is admin cookie set the custom age
     if is_admin: 
         request.session.set_expiry(settings.ADMIN_SESSION_COOKIE_AGE) 
-        
-        device_info = { 
-            "user_agent": request.META.get("HTTP_USER_AGENT",""),
-            "ip_address": request.META.get("REMOTE_ADDR", ""),
-            "domain": base_host(
-            request=request,
-            is_app=is_app,
-            is_admin=is_admin,
-            is_space=is_space,
-            ), 
-        }
+    
+    device_info = {
+        "user_agent": request.META.get("HTTP_USER_AGENT", ""),
+        "ip_address": request.META.get("REMOTE_ADDR", ""),
+        "domain": base_host(
+            request=request,
+            is_app=is_app,
+            is_admin=is_admin,
+            is_space=is_space
+        ),
+    }
     request.session["device_info"] = device_info
- 
-   
-    

These changes will improve code readability and maintain consistency throughout the file.

📜 Review details

Configuration used: CodeRabbit UI
Review profile: CHILL

📥 Commits

Files that changed from the base of the PR and between b1dccf3 and b7158b6.

📒 Files selected for processing (1)

• apiserver/plane/authentication/utils/login.py (1 hunks)