[WEB-5179] chore: icon utils code refactor

[anmolsinghbhatia]

Description

This PR includes code refactoring for icon utlis.

Type of Change

• Code refactoring

Summary by CodeRabbit

• Bug Fixes
  • Updated the default fallback icon for links to ensure consistent visual presentation across the application.

_{✏️ Tip: You can customize this high-level summary in your review settings.}

[makeplane]

Linked to Plane Work Item(s)

• [WEB-5179] Brand Icon System Revamp

This comment was auto-generated by Plane

[coderabbitai]

📝 Walkthrough

Walkthrough

The fallback icon in getIconForLink is updated from LinkIcon to Link2. The corresponding imports are modified—removing LinkIcon and adding Link2 from lucide-react. No public API signatures are altered.

Changes

Cohort / File(s)	Summary
Icon fallback update packages/utils/src/get-icon-for-link.ts	Replaced LinkIcon with Link2 in the default case; updated imports accordingly.

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~2 minutes

Poem

🐰 A link icon hops to a newer design,
Link2 now stands where LinkIcon did shine,
One little swap in the imports so neat,
Makes the fallback icon crisp and sweet!

Pre-merge checks and finishing touches

❌ Failed checks (1 inconclusive)

Check name	Status	Explanation	Resolution
Description check	❓ Inconclusive	The description is incomplete. While it correctly identifies the change type as code refactoring, it lacks detail about what was changed and is missing key template sections like Test Scenarios and References.	Expand the description with specific details about icon changes and complete the template by adding Test Scenarios and References sections.

✅ Passed checks (2 passed)

Check name	Status	Explanation
Title check	✅ Passed	The title 'chore: icon utils code refactor' accurately describes the main change, which is refactoring icon utility code by updating the fallback icon from LinkIcon to Link2.
Docstring Coverage	✅ Passed	No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.

✨ Finishing touches

• 📝 Generate docstrings

🧪 Generate unit tests (beta)

• Create PR with unit tests
• Post copyable unit tests in a comment
• Commit unit tests in branch chore-icon-utils-code-refactor

---

📜 Recent review details

Configuration used: defaults

Review profile: CHILL

Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 6cc5c19 and c76f53a.

📒 Files selected for processing (1)

• packages/utils/src/get-icon-for-link.ts

🧰 Additional context used

📓 Path-based instructions (4)

**/*.{ts,tsx,mts,cts}

📄 CodeRabbit inference engine (.github/instructions/typescript.instructions.md)

**/*.{ts,tsx,mts,cts}: Use const type parameters for more precise literal inference in TypeScript 5.0+
Use the satisfies operator to validate types without widening them
Leverage inferred type predicates to reduce the need for explicit is return types in filter/check functions
Use NoInfer<T> utility to block inference for specific type arguments when they should be determined by other arguments
Utilize narrowing in switch(true) blocks for control flow analysis (TypeScript 5.3+)
Rely on narrowing from direct boolean comparisons for type guards
Trust preserved narrowing in closures when variables aren't modified after the check (TypeScript 5.4+)
Use constant indices to narrow object/array properties (TypeScript 5.5+)
Use standard ECMAScript decorators (Stage 3) instead of legacy experimentalDecorators
Use using declarations for explicit resource management with Disposable pattern instead of manual cleanup (TypeScript 5.2+)
Use with { type: "json" } for import attributes; avoid deprecated assert syntax (TypeScript 5.3/5.8+)
Use import type explicitly when importing types to ensure they are erased during compilation, respecting verbatimModuleSyntax flag
Use .ts, .mts, .cts extensions in import type statements (TypeScript 5.2+)
Use import type { Type } from "mod" with { "resolution-mode": "import" } for specific module resolution contexts (TypeScript 5.3+)
Use new iterator methods (map, filter, etc.) if targeting modern environments (TypeScript 5.6+)
Utilize new Set methods like union, intersection, etc., when available (TypeScript 5.5+)
Use Object.groupBy / Map.groupBy standard methods for grouping instead of external libraries (TypeScript 5.4+)
Use Promise.withResolvers() for creating promises with exposed resolve/reject functions (TypeScript 5.7+)
Use copying array methods (toSorted, toSpliced, with) for immutable array operations (TypeScript 5.2+)
Avoid accessing instance fields via super in classes (TypeScript 5....

Files:

• packages/utils/src/get-icon-for-link.ts

**/*.{ts,tsx}

📄 CodeRabbit inference engine (AGENTS.md)

Enable TypeScript strict mode and ensure all files are fully typed

Files:

• packages/utils/src/get-icon-for-link.ts

**/*.{js,jsx,ts,tsx,json,css}

📄 CodeRabbit inference engine (AGENTS.md)

Use Prettier with Tailwind plugin for code formatting, run pnpm fix:format

Files:

• packages/utils/src/get-icon-for-link.ts

**/*.{js,jsx,ts,tsx}

📄 CodeRabbit inference engine (AGENTS.md)

**/*.{js,jsx,ts,tsx}: Use ESLint with shared config across packages, adhering to max warnings limits per package
Use camelCase for variable and function names, PascalCase for components and types
Use try-catch with proper error types and log errors appropriately

Files:

• packages/utils/src/get-icon-for-link.ts

⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (3)

• GitHub Check: CodeQL analysis (javascript-typescript)
• GitHub Check: Build packages
• GitHub Check: Analyze (javascript)

🔇 Additional comments (2)

packages/utils/src/get-icon-for-link.ts (2)

63-63: LGTM! Fallback icon updated correctly.

The fallback icon has been updated from LinkIcon to Link2, maintaining consistency with the import change. The nullish coalescing operator usage is appropriate.

---

19-19: No issues found. Link2 is a valid named export from lucide-react and is correctly imported and used as the fallback icon in the getIconForLink function.

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

_{Comment @coderabbitai help to get the list of available commands and usage tips.}

[Copilot]

Pull request overview

This PR refactors the icon utility code by replacing the LinkIcon import from @plane/propel/icons with Link2 from lucide-react, consolidating all icon imports to use the lucide-react library.

Key Changes:

• Standardizes icon imports to use lucide-react library exclusively
• Replaces LinkIcon with Link2 as the fallback icon for unmatched URLs

---

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.