Certora improvements #10
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sunbreak1211
added a commit
that referenced
this pull request
May 26, 2025
* DSChief => DssChief * Add constant for empty slate * Use unchecked for loops counter * Gas optimization Co-authored-by: telome <[email protected]> * Remove IOU * EMPTY_SLATE should be constant * Use ++i instead of i++ * Remove spacings * Extract TokenMock to separate file and change pragma for test file * Fix copyright TokenMock * Use Foundry default structure * Add tests CI * Fix CI * Fix test file name * No need of ETH_RPC_URL for CI * Spacing * Add Certora specs (#2) * Add Certora specs * Some renaming * New specs and minor changes to existing * Add spec * Add Certora CI * Fix mocks path * Add balances check for lock and free * Check extra values + Expand scope of existing checks + minor changes * Simplify some checks * Check gov balance in every rule * Old getters check * Run Certora CI on pull_request as well * Changes for running Certora * Use certora-cli-beta for now * Fix Certora script * Certora: move config to file * Certora: use double implication to make revert rules shorter * Rename + New flash loan protection (#4) * Flash loan protection in lift instead of free * Fix comments * Block flash loans also for launching + add some extra missing tests * Update README * Update Certora specs * Rename * Reorder and make constant public * Improve tests * nit changes * Certora: add spec for checking empty slate * Remove some retro-compatibility getters as they do not seem necessary * Remove paragraph from README * Use solc 0.8.21 * Use forge stable version * Minor README fix * Remove return values from GemLike interface as not used and is more gas efficient * Clarify mapping values * nit: remove some spaces * Simplify TokenMock * Minor test + spec changes * Remove not needed compatibility getter + minor test changes * Certora: some config changes * Improve hold require condition * Remove content from README * Certora: remove not necessary assert * Upgrade python and checkout versions for Certora CI * Fix typo * nit change * Gas optimization in _addWeight and _subWeight * Gas optimization * Remove unnecessary casting * Another gas optimization * Don't rely on actual order for processing expressions * Add basic integration test * Fix tests CI * Rename tests * Flash loan protection blocking free after launch/lift (#7) * Flash loan protection blocking free after launch/lift * Fixes in tests * Upgrade python version in Certora CI * Fixes on lift * Minor fix README * Remove unnecessary roll * lift cooldown as immutable * Update README.md for liftCooldown immutable Co-authored-by: telome <[email protected]> * Minor README fix * Add sender to some events * Add audit reports (#9) * Certora improvements (#10) --------- Co-authored-by: telome <[email protected]> Co-authored-by: oldchili <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.