Jon Clarke Chitter pull request by JonClarke84 · Pull Request #208 · makersacademy/chitter-challenge-apprenticeships

JonClarke84 · 2022-04-01T10:10:52Z

Your name

Jon Clarke

User stories

Please list which user stories you've implemented (delete the ones that don't apply).

User story 1: "I want to see all the messages (peeps) in a browser"
User story 2: "I want to post a message (peep) to chitter"
User story 3: "I want to see the date the message was posted"
User story 4: "I want to see a list of peeps in reverse chronological order"
User story 5: "I want to filter on a specific keyword"

README checklist

Does your README contains instructions for

how to install,
how to run,
and how to test your code?

Here is a pill that can help you write a great README!

estoltzy · 2022-04-04T08:52:10Z

@@ -0,0 +1,15 @@
+require 'pg'
+
+class DatabaseConnection


Great idea to split the database connection into a separate class - I hadn't thought to do this

estoltzy · 2022-04-04T08:53:06Z

+
+  class << self
+    attr_reader :connection
+  end


How does this class << self function? I haven't seen an attr_reader put inside a method like that before

This i a bit of metaprogramming.
A mix of: https://yehudakatz.com/2009/11/15/metaprogramming-in-ruby-its-all-about-the-self/
And the fact that all that
attr_reader :connection really does is:

def connection @connection end

So putting it all together, all these lines do is say:
Any time the connection class is used, it has a method called connection that will return the @connection variable value.

Another way to write this could have been:

def self.connection @connection end

This allows users of the class to use DatabaseConnection.connection

estoltzy · 2022-04-04T08:57:12Z

+.chitter-button:active {
+  box-shadow: 0 0 0 0 darkred;
+  transform: scale(96%);
+}


I'm impressed you put together a CSS style sheet! I'd love to see your webpage when we are on zoom. I wanted to give this a go but didn't end up having the time. It's really useful to see how a .css is laid out for my own understanding.

estoltzy · 2022-04-04T09:02:13Z

+
+<ul>
+  <% @peeps.reverse.each do |peep| %>
+    <li><%= peep.peep %> Posted on <%= peep.date %>.</li>


How does this peep.peep work? What is the .peep method?

@estoltzy this is the message of the peep.

@JonClarke84 - in terms of naming, the word "message" or "content" might be more meaningful.

alicelieutier

Great project overall, I like that you added styling.
I've added some comments, let me know if you have any questions.

alicelieutier · 2022-04-04T12:11:41Z

  get '/test' do
    'Test page'
  end


Detail - remove unused code

alicelieutier · 2022-04-04T12:12:30Z

+  get '/' do
+    @peeps = Peeps.all
+    erb :index
+  end
+
+  post '/add' do
+    Peeps.create(peep: params[:peep])
+    redirect '/'
+  end


If you wanted to make this more "standard", you could follow the restful routes naming conventions here: https://medium.com/@shubhangirajagrawal/the-7-restful-routes-a8e84201f206

alicelieutier · 2022-04-04T12:13:58Z

@@ -0,0 +1,15 @@
+require 'pg'
+
+class DatabaseConnection


alicelieutier · 2022-04-04T12:18:52Z

+
+  class << self
+    attr_reader :connection
+  end


This i a bit of metaprogramming.
A mix of: https://yehudakatz.com/2009/11/15/metaprogramming-in-ruby-its-all-about-the-self/
And the fact that all that
attr_reader :connection really does is:

def connection @connection end

So putting it all together, all these lines do is say:
Any time the connection class is used, it has a method called connection that will return the @connection variable value.

alicelieutier · 2022-04-04T12:19:57Z

+
+  class << self
+    attr_reader :connection
+  end


Another way to write this could have been:

def self.connection @connection end

alicelieutier · 2022-04-04T12:21:44Z

+
+  def self.create(peep:)
+    result = DatabaseConnection.query(
+      "INSERT INTO peeps (message) VALUES ('#{peep}') RETURNING id, message, date;"


Check this step walkthrough from the challenge to protect this agains SQL injections - https://github.com/makersacademy/course/blob/main/apprenticeships_bookmark_manager/walkthroughs/12.md

alicelieutier · 2022-04-04T12:22:02Z

+  end
+
+  def self.all
+    result = DatabaseConnection.query("SELECT * FROM peeps")


detail - add ; at end of query.

alicelieutier · 2022-04-04T12:23:54Z

+    add_row_to_test_database
+    visit('/')
+    expect(page).to have_content "This is a peep! Posted on 2022-04-01."
+  end


You can add a test for reverse chronological order. Check how you can use capybara matchers to match a regular expression.

alicelieutier · 2022-04-04T12:25:20Z

@@ -0,0 +1,43 @@
+require_relative 'database_connection'
+
+class Peeps


By convention, class names should be singular, table names plural.

alicelieutier · 2022-04-04T12:26:28Z

+
+<ul>
+  <% @peeps.reverse.each do |peep| %>
+    <li><%= peep.peep %> Posted on <%= peep.date %>.</li>


@estoltzy this is the message of the peep.

@JonClarke84 - in terms of naming, the word "message" or "content" might be more meaningful.

JonClarke84 added 9 commits April 1, 2022 10:26

setup complete, first tests passing

9a90345

first two user stories complete

997988b

added dates to peeps

2c99390

filter unit test passing

b79891e

search function is working

3127806

updated README

c564a5f

basic css

686d041

added better styling

5252d89

peep button sticks. Peeps not quite working under it yet

5e24121

estoltzy reviewed Apr 4, 2022

View reviewed changes

alicelieutier reviewed Apr 4, 2022

View reviewed changes

		@@ -0,0 +1,43 @@
		require_relative 'database_connection'

		class Peeps

Conversation

JonClarke84 commented Apr 1, 2022 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Your name

User stories

README checklist

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

alicelieutier left a comment

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

JonClarke84 commented Apr 1, 2022 •

edited

Loading