setup chitter#209
Open
PeterHattyar wants to merge 2 commits into
Open
Conversation
…riven and implemented.
siellsiell
reviewed
Apr 7, 2022
Contributor
siellsiell
left a comment
siellsiell
left a comment
There was a problem hiding this comment.
Hey,
I'm Simo, a coach. Thanks for submitting your code! This is a good start at the challenge. If you encountered blockers along the way, do reach out to your coach so that they can support.
Comment on lines
5
to
7
| get '/test' do | ||
| 'Test page' | ||
| end |
Contributor
There was a problem hiding this comment.
It's good practice to remove test code before submitting code for review (anywhere, not just at Makers)
|
|
||
| expect(page).to have_content "Welcome to Chitter!" | ||
| expect(page).to have_content "test-peep" | ||
| end |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.