1,2,3,4 user stories done#215
Conversation
mohamedadan92
left a comment
mohamedadan92
left a comment
There was a problem hiding this comment.
Great layout and easy to read app. No errors noticable
alicelieutier
left a comment
alicelieutier
left a comment
There was a problem hiding this comment.
Clear code, nicely separated and organised, well done!
I added a few comments below, let me know if anything doesn't make sense.
| get '/test' do | ||
| 'Test page' | ||
| get '/' do | ||
| 'Chitter App' |
| require 'sinatra/base' | ||
| require './lib/post' | ||
|
|
||
| class Chitter < Sinatra::Base |
| if ENV['ENVIRONMENT'] == 'test' | ||
| connection = PG.connect(dbname: 'chitter_test') | ||
| else | ||
| connection = PG.connect(dbname: 'chitter') | ||
| end |
There was a problem hiding this comment.
These lines are present in all your methods that access the db - they could be extracted into a database helper class :)
| else | ||
| connection = PG.connect(dbname: 'chitter') | ||
| end | ||
| result = connection.exec("SELECT * FROM peeps ORDER BY date DESC") |
There was a problem hiding this comment.
I'm surprised queries without ; work. I guess the framework adds the ;. I would still make sure to add it however.
| connection = PG.connect(dbname: 'chitter') | ||
| end | ||
|
|
||
| result = connection.exec_params("INSERT INTO peeps (date, author, message) VALUES('#{date}', $1, $2) RETURNING id, date, author, message;", [author, message]) |
There was a problem hiding this comment.
Nice that you are using exec_params to prevent sql injections here, but I'm wondering why you are not also doing that for the date, especially since the date is sent by the front-end as a param.
It would be different if the date was automatically added in ruby to peeps when they are created, and not coming from the front-end.
I know you form enforces a format for the input, but a malicious user could easily change the front-end html and send data in a different way, so your server should always protect itself from the front-end.
| expect(page).to have_content("2022-08-01") | ||
| expect(page).to have_content("2022-06-01") | ||
| expect(page).to have_content("2022-04-01") |
There was a problem hiding this comment.
This doesn't actually check the order of the content. You could use regular expressions here to check that "2022-08-01" is above "2022-06-01", for example with something like
expect(page).to match(/2022-08-01.*2022-06-01/)However, I think an even better test would check the content of the mew message comes before the content of an older one, this way the test would still pass if you decide to change the formatting of the date, given that the user story is about posts order, not dates :)
3 participants
Agnieszka Gotowiec
Please write your full name here to make it easier to find your pull request.
User stories
Please list which user stories you've implemented (delete the ones that don't apply).
README checklist
Does your README contains instructions for
Here is a pill that can help you write a great README!