Skip to content

new fork to fix clone error#225

Open
PhilipCarr1 wants to merge 1 commit into
makersacademy:mainfrom
PhilipCarr1:main
Open

new fork to fix clone error#225
PhilipCarr1 wants to merge 1 commit into
makersacademy:mainfrom
PhilipCarr1:main

Conversation

@PhilipCarr1
Copy link
Copy Markdown

Your name

Please write your full name here to make it easier to find your pull request.

User stories

Please list which user stories you've implemented (delete the ones that don't apply).

  • User story 1: "I want to see all the messages (peeps) in a browser"
  • User story 2: "I want to post a message (peep) to chitter"
  • User story 3: "I want to see the date the message was posted"
  • User story 4: "I want to see a list of peeps in reverse chronological order"
  • User story 5: "I want to filter on a specific keyword"

README checklist

Does your README contains instructions for

  • how to install,
  • how to run,
  • and how to test your code?

Here is a pill that can help you write a great README!

Comment thread app.rb
register Sinatra::Reloader
end

get '/test' do
Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You can delete this

@@ -0,0 +1,7 @@
require './lib/database_connection'

if ENV['ENVIRONMENT'] == 'test'
Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice extraction

@tomfuller
Copy link
Copy Markdown

Really nice neat solution, well done! The only thing I would say is it would be great if you could complete the checklist in the README and and include the instructions to run.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants