Pull request - Stephanie#226
Conversation
PhilipCarr1
left a comment
PhilipCarr1
left a comment
There was a problem hiding this comment.
everything looks good, solid start, looks like good foundations to finish the challenge :)
| erb :post | ||
| end | ||
|
|
||
| post '/postpeep' do |
There was a problem hiding this comment.
This route might be clearer and stick to conventions better if it were called '/peep/new'
| end | ||
|
|
||
| def self.all | ||
| if ENV['ENVIRONMENT'] == 'test' |
There was a problem hiding this comment.
could you not use the db setup helper here to remove this if else statement?
|
This is a really nice solution but it appears you have added user specific functionality before implementing the functionality from the user stories? You should always prioritise the functionality described in user stories that the business requires over nice to haves. It would also be really nice to see the README updated to include functionality finished and running instructions. I have left a couple inline comments where there are small things that could be improved. If you have any questions about any of this please let me know and we can chat! |
3 participants
Your name
Please write your full name here to make it easier to find your pull request.
User stories
Please list which user stories you've implemented (delete the ones that don't apply).
README checklist
Does your README contains instructions for
Here is a pill that can help you write a great README!