Hannah's Chitter Challenge#232
Conversation
siellsiell
left a comment
siellsiell
left a comment
There was a problem hiding this comment.
Hey Hannah,
This is a solid solution to the first two user stories, well done. You also showed that you have an understanding of how to alter existing database tables using migrations. I gave you a bit more detailed feedback and pointers below.
If you have any questions, feel free to respond to me here in the comments or send me a DM.
Simo
| | ---------- | ------------------------------------------- | --------------------------------- | | ||
| | Model | Encapsulate logic with relevant data | Encapsulate peep data in a class | | ||
| | View | Display the result to a user | Show the peep data in a list | | ||
| | Controller | Get data from the model and put in the view | Render peep data into to the view | |
There was a problem hiding this comment.
Nice to see your approach laid out like this, it shows good understanding of the MVC model.
| - list gems in the Gemfile: | ||
| source 'https://rubygems.org' | ||
|
|
||
| ruby '3.0.2' | ||
|
|
||
| gem 'pg' | ||
| gem 'sinatra' | ||
|
|
||
| group :test do | ||
| gem 'capybara' | ||
| gem 'rspec' | ||
| gem 'simplecov', require: false | ||
| gem 'simplecov-console', require: false | ||
| end | ||
|
|
||
| group :development, :test do | ||
| gem 'rubocop', '1.20' | ||
| end |
There was a problem hiding this comment.
Typically you'd leave details like that out of the README since those are already in your code. Someone that just wants the code will skip straight to how to install depedencies, tests and how to run the app (what you have described below). Someone interested in more details can take a look at the code inside the files.
| # configure :development do | ||
| # register Sinatra::Reloader | ||
| # end | ||
|
|
||
| # get '/' do | ||
| # 'Hello World' | ||
| # end |
There was a problem hiding this comment.
It's always a good idea to remove test code and commented out code from your files before you submit for code review (anywhere, not just at Makers). It's all about clean code :)
| @@ -0,0 +1 @@ | |||
| ALTER TABLE peeps ADD COLUMN username VARCHAR(60); No newline at end of file | |||
There was a problem hiding this comment.
Nice migration, it's easy to forget to add those!
| if ENV['ENVIRONMENT'] == 'test' | ||
| connection = PG.connect(dbname: 'chitter_test') | ||
| else | ||
| connection = PG.connect(dbname: 'chitter') | ||
| end |
There was a problem hiding this comment.
This piece of code appears several times in this file. How might you remove this duplication?
| # The first argument is our SQL query template | ||
| # The second argument is the 'params' referred to in exec_params | ||
| # $1 refers to the first item in the params array | ||
| # $2 refers to the second item in the params array | ||
| "INSERT INTO peeps (username, message) VALUES($1, $2) RETURNING id, username, message;", [username, message] |
| fill_in('message', with: 'An example of a peep') | ||
| click_button('Submit') | ||
|
|
||
| expect(page).to have_content 'Username, An example of a peep' |
| # visit('/') | ||
| # expect(page).to have_content "Hello World" | ||
| # end | ||
| # end |
There was a problem hiding this comment.
You can feel free to remove any seed files once you don't need them anymore :)
| expect(peeps.length).to eq 3 | ||
| expect(peeps.first).to be_a Peep | ||
| expect(peeps.first.id).to eq peep.id | ||
| expect(peeps.first.username).to eq 'User1' | ||
| expect(peeps.first.message).to eq 'This is a peep!' |
There was a problem hiding this comment.
It's great that you checked that every field in the peep matches what you expect.
Could you go further?
What if, for example, a bug was introduced in the future that causes Peep.all to return the first peep 3 times? Would your test catch this bug?
Since peeps have three things in it, a thorough test would be to check that each item in the array matches what you expect, not just the first one.
There was a problem hiding this comment.
Thank you Simo for your feedback!
This did happen (returning the first peep 3 times) and I didn't know how to deal with it.
I do hope to get the chance to come back and have another go at it 😊.
| # message = params['message'] | ||
| # connection = PG.connect(dbname: 'chitter_test') | ||
| # connection.exec("INSERT INTO peeps (message) VALUES('#{message}')") | ||
| Peep.create(message: params[:message], username: params[:username]) |
There was a problem hiding this comment.
Adding a username is a nice idea :)
2 participants
Hannah Akor
Please write your full name here to make it easier to find your pull request.
User stories
Please list which user stories you've implemented (delete the ones that don't apply).
README checklist
Does your README contains instructions for
Here is a pill that can help you write a great README!