Miranda code review#238
Open
MirandaFrudd wants to merge 1 commit into
Open
Conversation
siellsiell
reviewed
Jul 18, 2022
Contributor
siellsiell
left a comment
There was a problem hiding this comment.
Hey Ronan,
Your code looks good -- I like that you broke the problem down and started by implementing the user story without a database. It's a good base to build on and you've got all the classes that you'd need later on when you introduce the database.
Did you run into any blockers when it came to introducing the database part?
MirandaFrudd
commented
Jul 18, 2022
Author
MirandaFrudd
left a comment
There was a problem hiding this comment.
Your code is really easy to understand and is very neat. The controller is tidy and you seem to have followed the MVP model really well. Just need to link to the database and add in the next part of your user story (probably adding a comment).
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Your name
Please write your full name here to make it easier to find your pull request.
User stories
Please list which user stories you've implemented (delete the ones that don't apply).
README checklist
Does your README contains instructions for
Here is a pill that can help you write a great README!