Makers Chitter Challenge March 23 Cohort - #2171
Open
jonpillay wants to merge 3 commits into
Open
Conversation
added 3 commits
April 12, 2023 00:16
penguat
reviewed
Apr 12, 2023
penguat
left a comment
penguat
left a comment
There was a problem hiding this comment.
Hi Jon - i think there are a few places where you could have reviewed this yourself to see unnecessary code! Your structure looks good, and your code is clear, although you don't always break it up with newlines. You might consider when you need to make new methods to help out too.
There was a problem hiding this comment.
I'm not sure how this contributes to Chitter - could we delete it?
Comment on lines
+20
to
+25
| get '/' do | ||
| peeps_repo = PeepRepository.new | ||
| @user_repo = UserRepository.new | ||
| @peeps = peeps_repo.all | ||
| erb(:"app/index") | ||
| end |
Comment on lines
+27
to
+39
| post '/new' do | ||
| content = params[:content] | ||
| author = session[:user_id] | ||
| peep = Peep.new | ||
| peep.content = content | ||
| peep.author = author | ||
| peep_repository = PeepRepository.new | ||
| if peep.content.match(/@\w+/) | ||
| puts "we are here" | ||
| end | ||
| peep_repository.create(peep) | ||
| redirect '/' | ||
| end |
There was a problem hiding this comment.
This feels like it's doing a lot - could it be broken up to make it more digestible?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
All functionality working as pre spec, except for email. Needs CSS.