Will M - RPS challenge - #231
Open
wjmarshall wants to merge 3 commits into
Open
Conversation
Leigh-Rose
reviewed
Mar 28, 2022
Leigh-Rose
left a comment
Leigh-Rose
left a comment
There was a problem hiding this comment.
Just general comments really, formatted really well and is coherent. Comprehensive testing and good readability.
Not sure if the convention would be to include the choices as classes, I ran mine as logic but not sure of best practice in this respect. There were things I didn't understand going on in the weapon classes ("case" "<") due to a gap in my knowledge.
Contributor
|
Agreed with the above :) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.