Leigh Rose rock paper scissors version 1 - #234
Open
Leigh-Rose wants to merge 2 commits into
Open
Conversation
added 2 commits
March 25, 2022 16:23
wjmarshall
reviewed
Mar 28, 2022
wjmarshall
left a comment
wjmarshall
left a comment
There was a problem hiding this comment.
Hi Leigh, here are some thoughts I had while reading your code. Looks great!
| @@ -1,8 +1,33 @@ | |||
| require 'sinatra/base' | |||
There was a problem hiding this comment.
This seems a good, slim controller—logic is extracted to the lib files
| @@ -0,0 +1,24 @@ | |||
| class Game | |||
There was a problem hiding this comment.
Good use of single-responsibility principle in structuring of classes—each has a clear, single purpose
| def initialize(player) | ||
| end | ||
|
|
||
| def determine_winner(player_choice) |
There was a problem hiding this comment.
This seems quite a long method—perhaps there is a shorter solution?
| end | ||
|
|
||
| post '/names' do | ||
| $player_1 = Player.new(params[:player_1_name]) |
There was a problem hiding this comment.
Perhaps there is another solution to avoid using global variables?
| @@ -0,0 +1,8 @@ | |||
| class Player | |||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.