Farzan's RPS game (2 user stories complete)

[Farzan-I]

Farzan Imanzadeh

Completed the below user stories:

As a marketeer
So that I can see my name in lights
I would like to register my name before playing an online game

As a marketeer
So that I can enjoy myself away from the daily grind
I would like to be able to play rock/paper/scissors

Did not complete the bonus parts (multiplayer and RPSLS)

[S-Spiegl]

this feels like neat logic - very easy to read

[S-Spiegl]

You could consider keeping the computer in a separate class

[S-Spiegl]

Good, specific content requirements throughout the tests - I need to tighten mine up.

[eoinmakers]

Nice work on this! You've demonstrated the learning objectives of the week well.

My feedback revolves around refactoring to remove duplication of code - let me know if you have any questions.

You have a good range of unit & feature tests here, inc. stubbing the computer's move. Nice work! Fully comprehensive unit testing for this challenge would include unit tests for every combination of player/computer moves.

[eoinmakers]

Currently, you define a route for each player move option, and each of these routes uses mostly the same code. This is a duplication of code that could be refactored.

Another method of approach this logic is to pass in the player move as a parameter, calling the same route, and passing that param into the @GAMe instance.

[eoinmakers]

This approach can be simplified to make this class more concise. Check out the following approach: https://github.com/makersacademy/rps-challenge/blob/main/docs/review.md#use-of-ifelsif-conditionals-for-business-logic