Stevie Spiegl RPS - #2115
Conversation
| @@ -23,7 +23,6 @@ border='2' name='player_choice' type='submit' id='paper'></> | |||
| <input type="hidden" name="player_choice" value="paper" /> | |||
There was a problem hiding this comment.
Don't forget to indent everything! Makes it easier to read for others ;) Maybe even have blank lines between the parts that don't relate i.e. After each form to show where one stops and the other starts (this is only when you know a code review will be done)
| <form action='/play' method='post'> | ||
| <input type="text" name="player" style="padding: 5px 15px"><br><br> | ||
| <button type="submit" style="padding: 5px 10px">Submit name!</button> | ||
| </form> |
| <form action='/play_again' method='post'> | ||
| <button type="submit" style="padding: 5px 10px">Have another go?</button> | ||
| </form> | ||
| </body> |
There was a problem hiding this comment.
Same again. Takes maybe a day or two to write the code, but people would have to read it an unspecified amount of time
| @@ -5,7 +5,4 @@ | |||
| it "should return player's name" do | |||
There was a problem hiding this comment.
much better indentation here. Clear class names and tests. Nice one man!
| end | ||
| xit 'taunts the player if they lose' do | ||
| end | ||
| end |
There was a problem hiding this comment.
Empty file? I think you left the spec for this somewhere else? Then maybe you could delete this file
There was a problem hiding this comment.
Perhaps it would be good to consider what you might have tested in here if you had the time - you could even comment some ideas and come back to it at a later stage when you want to make improvements, especially the logic in Game is an important one.
| sign_in | ||
| click_on(id='scissors') | ||
| expect(page).to have_content "You chose wisely." | ||
| end |
There was a problem hiding this comment.
Really clear test scenarios, really enjoyed reading these if I'm honest. Good takeaway for my tests in the future, thank you!
There was a problem hiding this comment.
Agreed, good testing, well done for using stubs effectively here
| sign_in | ||
| expect(current_path).to eq('/play') | ||
| expect(page).to have_content('Alien') | ||
| end |
|
|
||
| # Start the server if this file is executed directly (don't change the line below) | ||
| run! if app_file == $0 | ||
| end |
There was a problem hiding this comment.
Great file, concise, good use of class names and instance and global variables
z-rasool
left a comment
z-rasool
left a comment
There was a problem hiding this comment.
Overall good file structure, use of stubs and identification of which objects to create. It would have been good to see some unit tests for Game, and perhaps something you can come to if you get the time in the future! Well done Stevie.
| elsif @player_weapon == :paper && @computer_weapon == :scissors | ||
| "You did not choose wisely." | ||
| end | ||
| end |
There was a problem hiding this comment.
Good to see the creation of a WEAPONS constant in this file. Could the engine method be refactored to reduce repetition - perhaps the use of a hash?
| sign_in | ||
| click_on(id='scissors') | ||
| expect(page).to have_content "You chose wisely." | ||
| end |
There was a problem hiding this comment.
Agreed, good testing, well done for using stubs effectively here
| end | ||
| xit 'taunts the player if they lose' do | ||
| end | ||
| end |
There was a problem hiding this comment.
Perhaps it would be good to consider what you might have tested in here if you had the time - you could even comment some ideas and come back to it at a later stage when you want to make improvements, especially the logic in Game is an important one.
| def select_weapon(weapon) | ||
| @weapon = weapon | ||
| end | ||
|
|
There was a problem hiding this comment.
Could the WEAPONS constant be used in this file too?
Improving tests
…ut would be better to get this back in its own class if possible
3 participants
No description provided.