RPS Challenge - #2125
Open
joe-mcgarry wants to merge 7 commits into
Open
Conversation
Aisha-Yusuff
reviewed
Jun 6, 2022
| <h3><%= @game.player_1.name %> chose <%= @game.get_player_1_choice %></h3> | ||
| <h3><%= @game.player_2.name %> chose <%= @game.get_player_2_choice %></h3> | ||
|
|
||
| <% if @game.get_player_1_choice == @game.get_player_2_choice %> |
There was a problem hiding this comment.
This logic in the view could be moved to a class. So, the view doesn't have to do too much work.
Aisha-Yusuff
reviewed
Jun 6, 2022
| @@ -0,0 +1,29 @@ | |||
| class Game | |||
There was a problem hiding this comment.
I really like this! It makes your code easy to follow and keeps the app.rb concise!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
My attempt at the RPS challenge, with a very simple implementation of multiplayer functionality