Hafiz Rps version - #2134
Open
Hafizalimi7 wants to merge 3 commits into
Open
Conversation
Jenniered
reviewed
Jun 6, 2022
Jenniered
left a comment
Jenniered
left a comment
There was a problem hiding this comment.
Set up, file base and logic look like a good start to the challenge. Added some comments for suggested additions.
| @object1 = params[:object1]#saving name | ||
| erb(:play2) | ||
| end | ||
|
|
| return @computer | ||
| end | ||
| end | ||
|
|
There was a problem hiding this comment.
Clear logic to show a win for the player
| visit('/start') | ||
| expect(page).to have_content 'Select Rock, Paper Or Scissor ?' | ||
| end | ||
| # scenario 'shows what computer has picked' do |
There was a problem hiding this comment.
I like that you're testing the content you see on the page is as it should be. Do you have a features test for submitting the player name?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.