Add Ruby 4.0.0 support and fixing failing tests #9
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
## Summary
This PR adds compatibility for Ruby 4.0.0 by addressing breaking changes in the Ruby runtime.
## Changes
### Thread variable access for Bullet notification collector
Ruby 4.0 / Bullet now uses `thread_variable_get/set` instead of hash-style accessor for thread-local variables.
```ruby
# Before
Thread.current[:bullet_notification_collector]
# After
Thread.current.thread_variable_get(:bullet_notification_collector)
```
### Backtrace format changes
Ruby 4.0 changed the backtrace format:
- Uses single quotes on both sides instead of backtick + single quote: `'method'` instead of `` `method' ``
- Includes class name in method: `'ClassName#method_name'` instead of `'method_name'`
Updated all regex patterns in `markers.rb` to support both formats.
### Hash#to_s output format
Ruby 4.0 changed `Hash#to_s` to use new-style syntax `{key: val}` instead of `{:key=>val}`.
Added `to_hash_rocket_syntax` helper method in `corrector_builder.rb` to ensure consistent output format.
### RSpec version update
Updated RSpec gems to versions compatible with Ruby 4.0:
- `rspec` ~> 3.12
- `rspec-rails` ~> 6.0
### Deprecated API fix
Fixed deprecated `config.fixture_path` to `config.fixture_paths` in `spec/rails_helper.rb`.
## Testing
All 28 examples pass on Ruby 4.0.0.
ydah
commented
Jan 11, 2026
| matrix: | ||
| os: [ubuntu-latest, macos-latest] | ||
| ruby: [2.7, 3.0, 3.1, 3.2, head] | ||
| ruby: ["3.0", "3.1", "3.2", "3.3", "3.4", "4.0", "head"] |
Contributor
Author
There was a problem hiding this comment.
I'd like to discuss this, but the 2.7 test fails during SQLite installation. I dropped it, but I'd like to know if there's a better workaround.
My current motivation is that this gem can't be used with Ruby versions close to the latest, so I'd like to incorporate this fix if possible.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This PR adds compatibility for Ruby 4.0.0 by addressing breaking changes in the Ruby runtime.
Changes
Thread variable access for Bullet notification collector
Ruby 4.0 / Bullet now uses
thread_variable_get/setinstead of hash-style accessor for thread-local variables.Backtrace format changes
Ruby 4.0 changed the backtrace format:
'method'instead of`method''ClassName#method_name'instead of'method_name'Updated all regex patterns in
markers.rbto support both formats.Hash#to_s output format
Ruby 4.0 changed
Hash#to_sto use new-style syntax{key: val}instead of{:key=>val}.Added
to_hash_rocket_syntaxhelper method incorrector_builder.rbto ensure consistent output format.RSpec version update
Updated RSpec gems to versions compatible with Ruby 4.0:
rspec~> 3.12rspec-rails~> 6.0Deprecated API fix
Fixed deprecated
config.fixture_pathtoconfig.fixture_pathsinspec/rails_helper.rb.Testing
All 28 examples pass on Ruby 4.0.0.