-
Notifications
You must be signed in to change notification settings - Fork 2
Callback routes #17
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Callback routes #17
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
regilero
commented
Feb 24, 2025
- Introduce OIDCHelper, as trying to manipulate routes directly from the provider would make infinite dependencies loops with settings.
- get_urlpatterns is moved inside OIDCHelper
- Side note: when using get_urlpatterns to generates routes in tests this must be defined in the test settings and cannotbe overriden later in individual tests, as the route assignement is done early
- Fix the callback_uri_name/callback_path/callback names mess tobe able to handle routes with prefix. e2e tests done in lemonldap integration currently.
gbip
reviewed
Feb 24, 2025
gbip
reviewed
Feb 24, 2025
gbip
reviewed
Feb 28, 2025
django_pyoidc/settings.py
Outdated
Comment on lines
174
to
176
op_definition[ | ||
"oidc_callback_path" | ||
] = f"{op_definition['oidc_paths_prefix']}-callback" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ici je pense qu'il faudrait résoudre le nom de l'url avec la fonction reverse (ou reverse_lazy) de jdango.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.