Skip to content

Callback routes #17

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 9 commits into from
Mar 18, 2025
Merged

Callback routes #17

merged 9 commits into from
Mar 18, 2025

Conversation

regilero
Copy link
Member

  • Introduce OIDCHelper, as trying to manipulate routes directly from the provider would make infinite dependencies loops with settings.
  • get_urlpatterns is moved inside OIDCHelper
  • Side note: when using get_urlpatterns to generates routes in tests this must be defined in the test settings and cannotbe overriden later in individual tests, as the route assignement is done early
  • Fix the callback_uri_name/callback_path/callback names mess tobe able to handle routes with prefix. e2e tests done in lemonldap integration currently.

Comment on lines 174 to 176
op_definition[
"oidc_callback_path"
] = f"{op_definition['oidc_paths_prefix']}-callback"
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ici je pense qu'il faudrait résoudre le nom de l'url avec la fonction reverse (ou reverse_lazy) de jdango.

@gbip gbip merged commit 9811f9f into main Mar 18, 2025
14 checks passed
@gbip gbip deleted the callback-routes branch March 18, 2025 10:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants