Switch jwt library from 'jwt' to 'PyJWT' #30
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gbip
force-pushed
the
switch_to_pyjwt
branch
2 times, most recently
from
3901680 to
55bf9e7
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
jwtandPyJWTlibraries are both incompatible, as their package are both namedjwt. A project relying on PyJWT to perform jwt operations will not be able to used django_pyoidc. This MR solves this issues by migrating fromjwttoPyJWTas it seems more maintained.There should be no security impact as JWT decoding is only performed for backchannel logout, and validation is then performed by pyoidc.