Fix: grid sampler bounds checking#82
Open
bashhack wants to merge 1 commit intomakiuchi-d:masterfrom
Open
Conversation
823cc38 to
52bfa39
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
y == heightwas nudged tofloat64(height)instead offloat64(height - 1)math.IsNaN/math.IsInfrejection for Go 1.24+ whereint(math.NaN())changed fromMinInt64to0, silently bypassing bounds checkscheckAndNudgePointsfrom a two-pass endpoint-only check to a single pass over all points, clamping moderate overshoot (within 5% of image dimension) instead of rejecting itpx >= width || py >= heightcheck inDefaultGridSampler.SampleGridWithTransformbecauseBitMatrix.Getalready returnsfalsefor out of bounds coordinatesContext
Perspective transforms may expectedly overshoot image edges by a few pixels. The old implementation rejected these outright, causing
NotFoundExceptionon valid QR codes. This proposed implementation clamps small overshoot to the nearest edge while still rejecting degenerate transforms (NaN, Inf, or far out of bounds).Testing
[x] All existing test packages pass
[x] New tests added for NaN/Inf, clamping behavior, far-out-of-bounds rejection and interior points checking