Skip to content

fix: resolve CI failures — ZLIB version, missing vcpkg action, duplicate YAML key#4416

Merged
makr-code merged 2 commits into
copilot/add-metadata-to-markdown-filesfrom
copilot/fix-commit-issue
Mar 25, 2026
Merged

fix: resolve CI failures — ZLIB version, missing vcpkg action, duplicate YAML key#4416
makr-code merged 2 commits into
copilot/add-metadata-to-markdown-filesfrom
copilot/fix-commit-issue

Conversation

Copilot AI commented Mar 25, 2026

Copy link
Copy Markdown
Contributor

Three independent CI failures from commit 059e3c48 caused cascading build/workflow failures. All are configuration defects unrelated to production code.

Description

ZLIB version constraint too strictcmake/Dependencies.cmake required ZLIB ≥ 1.3, but Ubuntu 22.04 ships 1.2.11, failing all Linux CI jobs at CMake configure time.

Non-existent GitHub Actionactions/setup-vcpkg@v1 does not exist on the Marketplace, causing all Windows durability test jobs to fail at startup before any build step ran.

Duplicate push: key in workflow YAMLwordpress-theme-deploy.yml had two push: keys under on:, the second silently shadowing the first. GitHub Actions parses this as a startup_failure (0 jobs run).

Type of Change

  • 🐛 Bug fix (non-breaking change which fixes an issue)
  • ✨ New feature (non-breaking change which adds functionality)
  • 💥 Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • 📝 Documentation update
  • ♻️ Code refactoring (no functional changes)
  • ⚡ Performance improvement
  • ✅ Test addition or update
  • 🔧 Configuration change
  • 🎨 UI/UX change

Related Issues

Changes Made

  • cmake/Dependencies.cmake: Lower minimum ZLIB requirement from 1.31.2 with inline comment explaining Ubuntu 22.04 compatibility rationale
  • .github/workflows/durability-tests.yml: Replace all three uses of actions/setup-vcpkg@v1 with lukka/run-vcpkg@v11; upgrade actions/upload-artifact@v3v4 (v3 deprecated)
  • .github/workflows/wordpress-theme-deploy.yml: Merge duplicate push: blocks into a single trigger covering both tags and branches/paths

Testing

Test Environment

  • OS: Ubuntu 22.04 / Windows (GitHub Actions)
  • Compiler: N/A (config-only changes)
  • Build Type: N/A

Test Results

  • All existing tests pass
  • New tests added for changes
  • Manual testing performed

Test Commands

# Verify YAML syntax
python3 -c "import yaml; yaml.safe_load(open('.github/workflows/wordpress-theme-deploy.yml'))"
python3 -c "import yaml; yaml.safe_load(open('.github/workflows/durability-tests.yml'))"

# Verify CMake ZLIB constraint
grep "ZLIB" cmake/Dependencies.cmake

Checklist

  • My code follows the coding standards
  • I have performed a self-review of my code
  • I have commented my code, particularly in hard-to-understand areas
  • I have updated the documentation accordingly
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • Any dependent changes have been merged and published

Code Quality

  • Code builds without errors
  • Code builds without warnings
  • Static analysis (cppcheck) passes
  • No memory leaks detected
  • Code follows C++17 standards

Documentation

  • README.md updated (if applicable)
  • CHANGELOG.md updated
  • API documentation updated (if applicable)
  • Code comments added/updated

Branch Strategy Compliance

  • PR targets the correct branch (develop for features, main for releases/hotfixes)
  • Branch naming follows convention (e.g., feature/, bugfix/, hotfix/, release/)
  • No direct commits to main or develop

Performance Impact

  • No significant performance impact
  • Performance improvement (describe below)
  • Performance regression (justify below)

Breaking Changes

No breaking changes. ZLIB 1.2 is a strict superset of what the codebase uses; lowering the floor does not affect runtime behavior.

Security Considerations

  • No security implications
  • Security review required
  • Dependencies updated to secure versions

Additional Notes

lukka/run-vcpkg@v11 is the de-facto standard vcpkg action for GitHub Actions and handles caching/bootstrapping automatically from the repo's vcpkg.json.

Screenshots/Logs

Before (Linux failure):

CMake Error: Could NOT find ZLIB: Found unsuitable version "1.2.11", but required is at least "1.3"

Before (Windows failure):

Unable to resolve action actions/setup-vcpkg, repository not found.

For Maintainers:

Review Checklist

  • Code quality acceptable
  • Tests adequate
  • Documentation complete
  • No security concerns
  • Ready to merge

Merge Strategy

  • Squash and merge (✅ Recommended for feature/bugfix PRs - cleaner history)
  • Merge commit (Only for release/hotfix branches)
  • Rebase and merge
Original prompt

Reference: https://github.com/makr-code/ThemisDB/commit/059e3c48c4b3f7f65fa091afa359eedfb0f57744/checks?check_suite_id=57630684622

fix it


💬 Send tasks to Copilot coding agent from Slack and Teams to turn conversations into code. Copilot posts an update in your thread when it's finished.

- Lower ZLIB minimum version from 1.3 to 1.2 for Ubuntu 22.04 compatibility
- Replace non-existent actions/setup-vcpkg@v1 with lukka/run-vcpkg@v11
- Upgrade actions/upload-artifact@v3 to v4
- Fix duplicate push key in wordpress-theme-deploy.yml on section

Co-authored-by: makr-code <150588092+makr-code@users.noreply.github.com>
Agent-Logs-Url: https://github.com/makr-code/ThemisDB/sessions/b3d97986-51b3-41ea-b5f8-7d7f8036d946
Copilot AI changed the title [WIP] Fix commit issue in ThemisDB fix: resolve CI failures — ZLIB version, missing vcpkg action, duplicate YAML key Mar 25, 2026
Copilot AI requested a review from makr-code March 25, 2026 10:36
@makr-code makr-code marked this pull request as ready for review March 25, 2026 10:57
@makr-code makr-code merged commit f04d1ed into copilot/add-metadata-to-markdown-files Mar 25, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants