fix: resolve CI failures — ZLIB version, missing vcpkg action, duplicate YAML key#4416
Merged
makr-code merged 2 commits intoMar 25, 2026
Merged
Conversation
- Lower ZLIB minimum version from 1.3 to 1.2 for Ubuntu 22.04 compatibility - Replace non-existent actions/setup-vcpkg@v1 with lukka/run-vcpkg@v11 - Upgrade actions/upload-artifact@v3 to v4 - Fix duplicate push key in wordpress-theme-deploy.yml on section Co-authored-by: makr-code <150588092+makr-code@users.noreply.github.com> Agent-Logs-Url: https://github.com/makr-code/ThemisDB/sessions/b3d97986-51b3-41ea-b5f8-7d7f8036d946
Copilot
AI
changed the title
[WIP] Fix commit issue in ThemisDB
fix: resolve CI failures — ZLIB version, missing vcpkg action, duplicate YAML key
Mar 25, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Three independent CI failures from commit
059e3c48caused cascading build/workflow failures. All are configuration defects unrelated to production code.Description
ZLIB version constraint too strict —
cmake/Dependencies.cmakerequired ZLIB ≥ 1.3, but Ubuntu 22.04 ships 1.2.11, failing all Linux CI jobs at CMake configure time.Non-existent GitHub Action —
actions/setup-vcpkg@v1does not exist on the Marketplace, causing all Windows durability test jobs to fail at startup before any build step ran.Duplicate
push:key in workflow YAML —wordpress-theme-deploy.ymlhad twopush:keys underon:, the second silently shadowing the first. GitHub Actions parses this as astartup_failure(0 jobs run).Type of Change
Related Issues
Changes Made
cmake/Dependencies.cmake: Lower minimum ZLIB requirement from1.3→1.2with inline comment explaining Ubuntu 22.04 compatibility rationale.github/workflows/durability-tests.yml: Replace all three uses ofactions/setup-vcpkg@v1withlukka/run-vcpkg@v11; upgradeactions/upload-artifact@v3→v4(v3 deprecated).github/workflows/wordpress-theme-deploy.yml: Merge duplicatepush:blocks into a single trigger covering bothtagsandbranches/pathsTesting
Test Environment
Test Results
Test Commands
Checklist
Code Quality
Documentation
Branch Strategy Compliance
developfor features,mainfor releases/hotfixes)feature/,bugfix/,hotfix/,release/)mainordevelopPerformance Impact
Breaking Changes
No breaking changes. ZLIB 1.2 is a strict superset of what the codebase uses; lowering the floor does not affect runtime behavior.
Security Considerations
Additional Notes
lukka/run-vcpkg@v11is the de-facto standard vcpkg action for GitHub Actions and handles caching/bootstrapping automatically from the repo'svcpkg.json.Screenshots/Logs
Before (Linux failure):
Before (Windows failure):
For Maintainers:
Review Checklist
Merge Strategy
Original prompt
💬 Send tasks to Copilot coding agent from Slack and Teams to turn conversations into code. Copilot posts an update in your thread when it's finished.