Add explicit top-k group validation in uplift_at_k#226
Open
RiukaRin wants to merge 1 commit into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
name: "Pull request"
about: Make changes in scikit-uplift
📑 Description of the Change
This PR adds explicit validation to uplift_at_k(..., strategy="overall") so the top-k slice must contain both treatment and control samples.
Previously, this edge case could return nan. Now it raises a clear ValueError with a helpful message instead.
Verification Process
Verified the updated code path with direct runtime checks.
Confirmed that uplift_at_k(..., strategy="overall") raises ValueError when one group is missing in the selected top-k slice.
Confirmed that valid inputs still return a finite score.
Release Notes
Improve uplift_at_k validation for empty-group top-k edge cases.
Additional info
This PR is intentionally focused on the uplift_at_k fix only.