Handle empty SNP/AA results in allele frequency tests - #1066
Draft
adilraza99 wants to merge 7 commits into
Draft
Conversation
adilraza99
marked this pull request as draft
March 19, 2026 04:37
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fix a transient failure in allele frequency tests caused by random parameter combinations producing empty results.
Changes
ValueErrorwhen random parameters yield:test_allele_frequencies_with_str_cohorts_and_sample_querytest_allele_frequencies_with_str_cohorts_and_sample_query_optionsRationale
The functions
snp_allele_frequencies()andaa_allele_frequencies()correctly raiseValueErrorwhen no variants remain after filtering. Randomized test inputs canlegitimately trigger this case, causing intermittent failures.
The tests now return early when this situation occurs, following the existing
pattern already used elsewhere in the test suite.
Impact
No changes to library behaviour.
This only stabilizes the test suite by handling valid edge cases.
Closes #1064