Add LD-pruned biallelic SNP access method - #1067
Closed
adilraza99 wants to merge 7 commits into
Closed
Conversation
adilraza99
force-pushed
the
GH-1049-add-ld-pruning-support
branch
from
March 7, 2026 06:28
4795931 to
c4aae55
Compare
Contributor
Author
|
Hi @jonbrenas, I ran a quick local check of the new method on a small region. The LD-pruned dataset returns fewer variants than the original SNP calls and behaves as expected with the existing pipeline. |
adilraza99
force-pushed
the
GH-1049-add-ld-pruning-support
branch
from
March 7, 2026 07:00
c4aae55 to
7a55c6c
Compare
adilraza99
force-pushed
the
GH-1049-add-ld-pruning-support
branch
from
March 7, 2026 09:42
7a55c6c to
08903d4
Compare
Contributor
Author
|
@jonbrenas could you take a look at this when you have a moment? |
Contributor
Author
|
Hi @jonbrenas, thanks for the clarification. I tried an implementation based on the discussion and also ran a quick local verification where the variant count decreases after pruning. When you have time, could you please take a look and let me know if this direction makes sense? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

Summary
Add support for generating LD-pruned SNP datasets from the existing biallelic SNP call pipeline.
Changes
AnophelesLdAnalysismixinbiallelic_snp_calls_ld_pruned()methodld_params.pyfor LD pruning parametersAnophelesDataResourceImplementation
The method builds on top of
biallelic_snp_calls():allel.locate_unlinked_dask_compress_datasetxarray.DatasetNotes
n_snpsparameterTests
Added tests to verify:
closes #1049