Fix: add sample_indices parameter to count_samples, plot_samples_interactive_map, plot_samples_bar, plot_sample_location_geo - #1127
Merged
jonbrenas merged 3 commits intoMar 20, 2026
Conversation
…ractive_map, plot_samples_bar, plot_sample_location_geo
jonbrenas
approved these changes
Mar 20, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #1126
## What this fixes
Four public methods that call
sample_metadata()internally were missingthe
sample_indicesparameter thatsample_metadata()exposes. This meantusers could not select samples by index when using these methods.
## Changes
Added
sample_indices: Optional[base_params.sample_indices] = Nonetothe signatures of:
count_samples()plot_samples_interactive_map()plot_samples_bar()plot_sample_location_geo()And passed
sample_indices=sample_indicesthrough to the internalsample_metadata()call in each method.## Pattern followed
wgs_data_catalog()already correctly implements this pattern —this PR applies the same approach to the four affected methods.
## Testing