Better defaults for chunks parameters #704
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I'll try re-running the integration and notebook tests here, to see if it automatically picks up the fix for gcsfs. Ref: issue #782 |
|
By the way, did we ever find out whether this was what was in mind? I wonder if there is a way to confirm, e.g. if performance is improved and nothing breaks and it seems to make sense to others, etc. |
|
I am not sure that was exactly what @alimanfoo had in mind. I think there is a piece of chunk optimisation in the PCA part of the cohort analysis which is what he meant to do but I have not checked that it does the same thing as this. I'll move this PR back to draft to force myself to remember to check it. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Addresses #629.
This is just a prototype to check that it is what @alimanfoo had in mind. I have not tested that it actually improves performances yet.
If that's the correct idea, I will extend that to other similar functions.