Skip to content

Fix Windows path compatibility in cloud storage URLs #784

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Fix Windows path compatibility in cloud storage URLs #784

wants to merge 2 commits into from

Conversation

mohamed-laarej
Copy link
Collaborator

Re: issue #783

@jonbrenas
Copy link
Collaborator

Thanks @mohamed-laarej. This looks great. The only issue is that the integration and notebooks tests fail because you are working from a fork. Would it be possible to transfer your changes to a clone of the repo and create a new PR (or shadow this PR if you find it easier)?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@mohamed-laarej @jonbrenas