Merged
Conversation
…istency and clarity In C++ library code, it’s generally considered bad practice to use assert for input validation or error handling. --Stripped in release builds assert() is disabled if NDEBUG is defined (typical for optimized builds), so important checks may silently disappear. --Terminates the program assert calls abort() on failure — not ideal for libraries meant to be reused safely by others. --Not user-friendly Gives no chance to recover or handle the failure gracefully. --Violates encapsulation Forces application behavior based on internal library assumptions.
Replaced unqualified `move` with explicit `std::move` in to ensure clarity and compliance with modern C++ standards. Fix warning about unqualified-std-cast-call warning: unqualified call to 'std::move' [-Wunqualified-std-cast-call]
Contributor
Author
|
@malaterre Do you have comments about this change? I wanted to avoid asserts that cause applications to crash when exceptions can be caught. |
issakomi
reviewed
Jun 1, 2025
Owner
|
Thanks, will start a GDCM 3.2.x with this changeset. kudos for preparing it. |
Open
7 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
in C++ library code, it’s generally considered bad practice to use assert for input validation or error handling. Here’s why, and what to do instead:
⸻
Stripped in release builds
assert() is disabled if NDEBUG is defined (typical for optimized builds), so important checks may silently disappear.
Terminates the program
assert calls abort() on failure — not ideal for libraries meant to be reused safely by others.
Not user-friendly
Gives no chance to recover or handle the failure gracefully.
Violates encapsulation
Forces application behavior based on internal library assumptions.