This repository was archived by the owner on Sep 8, 2026. It is now read-only.
fix(sentinel): improve previous epoch slot evaluation - #213
Merged
Conversation
karl-dz
marked this pull request as ready for review
November 26, 2025 21:19
vihu
approved these changes
Nov 26, 2025
bgm-malbeclabs
pushed a commit
to malbeclabs/doublezero
that referenced
this pull request
Aug 28, 2026
…blezero-offchain#213) ## Summary of Changes When using a local validator, the leader schedule check will always fail because the previous epoch slot iterator will always return `None` since the current slot will always be less than 432,000 slots (the number of slots in an epoch). So if we were to test the Sentinel in a local environment, it never has a chance of granting access. This PR fixes this iterator evaluation. This change also makes `PreviousEpochSlots` private since nothing else would use it besides this submodule. Closes #2306. ## Testing Verification Unit tests still pass.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary of Changes
When using a local validator, the leader schedule check will always fail because the previous epoch slot iterator will always return
Nonesince the current slot will always be less than 432,000 slots (the number of slots in an epoch). So if we were to test the Sentinel in a local environment, it never has a chance of granting access. This PR fixes this iterator evaluation.This change also makes
PreviousEpochSlotsprivate since nothing else would use it besides this submodule.Closes malbeclabs/doublezero#2306.
Testing Verification
Unit tests still pass.