Skip to content
This repository was archived by the owner on Sep 8, 2026. It is now read-only.

feat(validator-debt): add overrides option to validator debt payment - #216

Merged
karl-dz merged 4 commits into
mainfrom
bgm/override_validators
Dec 2, 2025
Merged

feat(validator-debt): add overrides option to validator debt payment#216
karl-dz merged 4 commits into
mainfrom
bgm/override_validators

Conversation

@bgm-malbeclabs

@bgm-malbeclabs bgm-malbeclabs commented Nov 29, 2025

Copy link
Copy Markdown
Collaborator

Summary of Changes

This PR adds an overrides.csv to exclude validators from an epoch or epochs from debt collection. The attached overrides.csv outlines the validators and epochs they are to be excluded from:

overrides.csv

Note that this is a temporary fix; the longer term fix will be using onchain data and writing data onchain.

Closes malbeclabs/doublezero#2316.

Testing Verification

  • This was run locally against epoch 60:
                                                                                                  7VZM7YHcX73TpGoXDeBu61g4QKC86GwAEnew8dA7Y2xn: Some(
                                                                                                                                                           "Program log: Merkle leaf index 89 has already been processed",
                                             )
                                              7ZjHeeYEesmBs4N6aDvCQimKdtJX2bs5boXpJmpG2bZJ: Some(
                                                                                                     "Program log: Insufficient funds in Solana validator deposit to pay debt",
  )
   Validator 7cVfgArCheMR6Cs4t6vz5rfnqd56vZq4ndaBrY5xkxXy for epoch #60 excluded from debt collection
                                                                                                     7knvB4bbqHCKuNp3ef2hJWdwqoH6WAUi55NQt6LdRfkx: Some(
                                                                                                                                                            "Program log: Merkle leaf index 92 has already been processed",
                                              )

In the admittedly convoluted logs, the 7cVfgArCheMR6Cs4t6vz5rfnqd56vZq4ndaBrY5xkxXy is excluded

@bgm-malbeclabs
bgm-malbeclabs requested review from Copilot and karl-dz and removed request for Copilot November 29, 2025 00:53
Comment thread crates/validator-debt/src/transaction.rs Outdated
Comment thread crates/validator-debt/src/transaction.rs

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Adds an "overrides" mechanism to skip validator debt payments for specified validators/epochs by reading a CSV file, intended as a temporary workaround until on-chain data is used.

  • Introduces reading overrides from a CSV at a fixed path and builds a list of (pubkey, epoch) entries
  • Skips processing debts matching an override for the current epoch

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Comment thread crates/validator-debt/src/transaction.rs
Comment thread crates/validator-debt/src/transaction.rs
Comment thread crates/validator-debt/src/transaction.rs
@bgm-malbeclabs bgm-malbeclabs self-assigned this Dec 1, 2025

@karl-dz karl-dz left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reasonable hack

@karl-dz
karl-dz merged commit cbef1f8 into main Dec 2, 2025
2 checks passed
@karl-dz
karl-dz deleted the bgm/override_validators branch December 2, 2025 16:34
bgm-malbeclabs added a commit to malbeclabs/doublezero that referenced this pull request Aug 28, 2026
…albeclabs/doublezero-offchain#216)

## Summary of Changes
This PR adds an `overrides.csv` to exclude validators from an epoch or
epochs from debt collection. The attached `overrides.csv` outlines the
validators and epochs they are to be excluded from:


[overrides.csv](https://github.com/user-attachments/files/23864374/overrides.csv)

Note that this is a temporary fix; the longer term fix will be using
onchain data and writing data onchain.

Closes #2316.

## Testing Verification
* This was run locally against epoch 60: 
```
                                                                                                  7VZM7YHcX73TpGoXDeBu61g4QKC86GwAEnew8dA7Y2xn: Some(
                                                                                                                                                           "Program log: Merkle leaf index 89 has already been processed",
                                             )
                                              7ZjHeeYEesmBs4N6aDvCQimKdtJX2bs5boXpJmpG2bZJ: Some(
                                                                                                     "Program log: Insufficient funds in Solana validator deposit to pay debt",
  )
   Validator 7cVfgArCheMR6Cs4t6vz5rfnqd56vZq4ndaBrY5xkxXy for epoch malbeclabs/doublezero-offchain#60 excluded from debt collection
                                                                                                     7knvB4bbqHCKuNp3ef2hJWdwqoH6WAUi55NQt6LdRfkx: Some(
                                                                                                                                                            "Program log: Merkle leaf index 92 has already been processed",
                                              )
```

In the admittedly convoluted logs, the
`7cVfgArCheMR6Cs4t6vz5rfnqd56vZq4ndaBrY5xkxXy` is excluded
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Add overrides file to exclude validators from debt collection

3 participants