telemetry: geoprobe-target clickhouse fixes - #3533
Merged
Merged
Conversation
The clickhouse-go driver expects a plain host:port address but config.env values sometimes include an https:// prefix, causing "too many colons in address" errors. Match the controller's existing behavior by stripping http:// and https:// prefixes.
nikw9944
force-pushed
the
nikw/geoprobe-target-ch-fix
branch
from
April 15, 2026 15:03
4300ef3 to
71107f6
Compare
RunMigrations creates its own clickhouse connection that was also missing Protocol: clickhouse.HTTP, causing the same handshake error on port 8443.
ClickhouseWriter now owns its connection lifecycle: it takes a config instead of a pre-established connection, and connects lazily on the first tick. If connection or migration fails, it logs an error and retries on the next 10s tick instead of crashing the process. Buffered rows are capped at 10k to bound memory while disconnected. Flush errors close the connection so the next tick triggers reconnect.
nikw9944
changed the title
nikw9944
changed the title
ben-dz
approved these changes
Apr 15, 2026
nikw9944
enabled auto-merge (squash)
April 15, 2026 17:35
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
https://andhttp://scheme prefixes fromCLICKHOUSE_ADDR— the clickhouse-go driver expects plainhost:portTesting Verification
TestClickhouseConfigFromEnv: verifies scheme stripping for plain,https://, andhttp://addressesTestClickhouseWriterRecordBuffers: verifies basic buffering via the new constructorTestClickhouseWriterRecordBufferCap: verifies buffer does not exceed 10k rowsams-mn-gm1and confirmed clickhouse is working, and also that probes are received successfully without clickhouse configured