Skip to content

device-health-oracle: add interface_counters activation criterion - #3535

Merged
nikw9944 merged 4 commits into
mainfrom
nikw9944/doublezero-2671
Apr 16, 2026
Merged

device-health-oracle: add interface_counters activation criterion#3535
nikw9944 merged 4 commits into
mainfrom
nikw9944/doublezero-2671

Conversation

@nikw9944

@nikw9944 nikw9944 commented Apr 15, 2026 •
edited
Loading

Copy link
Copy Markdown
Contributor

Summary of Changes

Related: RFC 12 — Network Provisioning

Testing Verification

  • All device-health-oracle unit tests pass (34 tests), including 8 new tests covering the InterfaceCountersCriterion and InterfaceCountersCoverage methods
  • Tests cover: pass/fail scenarios, ClickHouse errors, missing burn-in context, zero-length burn-in, provisioning vs. drained start time selection, correct table/column names in queries, database name quoting

@nikw9944 nikw9944 mentioned this pull request Apr 15, 2026
Closed
@nikw9944 nikw9944 changed the title device-health-oracle: add interface_counters activation criterion device-health-oracle: add metrics activation criterion Apr 15, 2026
@nikw9944
nikw9944 force-pushed the nikw9944/doublezero-2671 branch from a3325d1 to 6d475fa Compare April 15, 2026 19:19
@nikw9944
nikw9944 marked this pull request as ready for review April 15, 2026 19:25
@nikw9944
nikw9944 requested a review from martinsander00 April 15, 2026 19:25
@nikw9944 nikw9944 changed the title device-health-oracle: add metrics activation criterion device-health-oracle: add interface_counters activation criterion Apr 15, 2026
martinsander00
martinsander00 reviewed Apr 16, 2026
View reviewed changes
Comment thread controlplane/device-health-oracle/cmd/device-health-oracle/main.go Outdated
martinsander00
martinsander00 reviewed Apr 16, 2026
View reviewed changes
Comment thread controlplane/device-health-oracle/internal/worker/clickhouse.go Outdated
nikw9944 added 4 commits April 16, 2026 14:49
@nikw9944
device-health-oracle: add interface_counters activation criterion (#2671
20b8439 
)

Add InterfaceCountersCriterion that verifies pending devices have at least
1 record per minute in the ClickHouse fact_dz_device_interface_counters
table throughout the burn-in period. This ensures devices are reporting
interface telemetry data before they can advance to ReadyForLinks.
@nikw9944
device-health-oracle: update log message to reflect all ClickHouse-ba…
9fb11dd 
…sed criteria
@nikw9944
device-health-oracle: add changelog entry for interface_counters crit…
f69ac9d 
…erion
@nikw9944
device-health-oracle: update rfc12 to reflect ClickHouse as data sour…
938575a 
…ce (#2671)
@nikw9944
nikw9944 force-pushed the nikw9944/doublezero-2671 branch from 45699fa to 938575a Compare April 16, 2026 14:50
@nikw9944
nikw9944 enabled auto-merge (squash) April 16, 2026 14:50
@nikw9944
nikw9944 merged commit bdb1398 into main Apr 16, 2026
42 of 81 checks passed
@nikw9944
nikw9944 deleted the nikw9944/doublezero-2671 branch April 16, 2026 18:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@martinsander00 martinsander00 martinsander00 approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

device-health-oracle: Add activation criterion: a pending device has <burn-in slots> of data in the ClickHouse fact_dz_device_interface_counters table

2 participants

@nikw9944 @martinsander00