qa: use CommitmentFinalized for USDC balance check - #3542
Merged
Conversation
martinsander00
approved these changes
Apr 16, 2026
packethog
approved these changes
Apr 16, 2026
packethog
added a commit
that referenced
this pull request
Apr 16, 2026
…3543) ## Summary of Changes * Poll the USDC balance with `require.Eventually` in `validate_balance_after_pay` and `validate_balance_after_withdraw` instead of a single read, with a 30s timeout and 5s interval. * Fixes a race between `FeedSeatPay`/`FeedSeatWithdraw` (which return after tx **confirmation**) and `GetUSDCBalance` at `CommitmentFinalized` — mainnet finalization lags confirmation by ~13s, so a one-shot finalized read can still see the pre-debit balance. * PR #3542 (commitment bump alone) was insufficient: the failure reproduced immediately at [run 24534512863](https://github.com/malbeclabs/infra/actions/runs/24534512863/job/71732161416), with before/after balance identical because the finalized-slot view predated the pay tx. * 5s poll interval chosen to avoid RPC rate limiting. ## Testing Verification * `go build -tags=qa ./e2e/...` and `go vet -tags=qa ./e2e/...` pass. * Run failure signature reproduced: `balanceBeforePay=1008431000`, `balanceAfterPay=1008431000`, debit=0, polled one ~115ms after `FeedSeatPay` returned. With polling, the assertion has up to 30s for the finalized slot to advance past the pay tx.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary of Changes
GetTokenAccountBalancecommitment level fromCommitmentConfirmedtoCommitmentFinalizedwhen checking USDC balances in the QA settlement testTesting Verification
TestQA_MulticastSettlement/validate_balance_after_payfailure seen in https://github.com/malbeclabs/infra/actions/runs/24531910905/job/71717025418, where the balance was read immediately after a transaction was confirmed but before it was finalized, causing the debit to not yet be visible