CI versioning fixes - #34
Merged
Merged
Conversation
… having now version in their names
There was a problem hiding this comment.
Pull Request Overview
This PR addresses CI versioning issues by ensuring version information is properly embedded into library binaries and adding version tags to release archives. The changes improve build numbering and make releases more identifiable.
- Fixes version component ordering in the plugin binary to match GitHub UI expectations
- Adds build number support to the CMake configuration with proper defaults
- Updates CI workflows to generate and use build numbers consistently across all steps
Reviewed Changes
Copilot reviewed 5 out of 5 changed files in this pull request and generated 3 comments.
Show a summary per file
| File | Description |
|---|---|
src/version.hpp.in |
Reorders version components and adds build number to PLUGIN_VERSION macro |
CMakeLists.txt |
Adds PLUGIN_VER_BUILD variable with default value |
.github/workflows/quick-build-and-test.yml |
Passes build number and version tag parameters for testing |
.github/workflows/package-releases.yml |
Adds version calculation job and refactors to share version data across jobs |
.github/workflows/build-library.yml |
Updates to accept and use build number and version tag in artifact naming |
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
…cessary version - after the plugin is launched it starts librespot; and in fail case offers user to pick up any available device on his choice
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.