You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
This PR adds a X-Payment-Receipt header to the proxy response when the request is routed through a /proxy path. This allows the SDK to retrieve the payment receipt immediately for streaming requests.
Hi! 👋 main has moved forward significantly today — 19 PRs were merged, and this PR currently has merge conflicts with the new main.
To get this reviewed and merged: please rebase your branch onto main, resolve the conflicts, and force-push. The updated main includes recent work on health checks, dark mode, k8s manifests, the Python SDK, wallet tests, escrow integration, and shared dashboard error components — so there may now be overlap to reconcile with your change.
Happy to take another look once it's rebased. Thanks! 🙏
Thanks for the contribution! This was part of the Stellar Wave 8 / GrantFox issue set. The issue this addresses is now implemented directly in main, which was substantially reworked during a full audit pass, so this PR is superseded and its changes conflict with the current implementation of the same feature.
Closing as superseded. If you believe part of this work is not covered by the current main, please open a fresh PR against the current codebase.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #46
Description
This PR adds a
X-Payment-Receiptheader to the proxy response when the request is routed through a/proxypath. This allows the SDK to retrieve the payment receipt immediately for streaming requests.Related Issue
Fixes #46
Type of Change
Checklist
pnpm lintand fixed all errorsTesting
Verified with manual inspection of
ProxyControllerlogic and ensuring the header is set only for routes starting with/proxy.