Check that message is hashable before calling translate on it#442
Closed
Check that message is hashable before calling translate on it#442
Conversation
mauritsvanrees
approved these changes
Jun 12, 2025
mauritsvanrees
left a comment
mauritsvanrees
left a comment
There was a problem hiding this comment.
This helps for me. Thanks!
Tested in a Plone 6.0 project by reverting this workaround in plone.namedfile.
Tested by editing chameleon/i18n.py manually, because master is not usable for me due to issue #438, so possibly a backport to a 4.4.x branch could be useful.
Pull Request Test Coverage Report for Build 15613017608Details
💛 - Coveralls |
Owner
Author
|
Closing this because we're instead leaving the responsibility to downstream consumers of the package (who can better know which objects to translate). |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This fixes issue #441.