-
Notifications
You must be signed in to change notification settings - Fork 419
feat: Support environment variables modifications #4106
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #4106 +/- ##
==========================================
- Coverage 63.48% 63.30% -0.18%
==========================================
Files 315 315
Lines 38644 38751 +107
Branches 2969 2980 +11
==========================================
Hits 24532 24532
- Misses 14043 14150 +107
Partials 69 69 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
5248b03 to
854417d
Compare
jjerphan
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Comments for reviewers.
6bdac58 to
954c23b
Compare
Klaim
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, all my remarks are nitpicks, nothing important 👍🏽
f2ab756 to
d5ce5ca
Compare
Signed-off-by: Julien Jerphanion <[email protected]>
Signed-off-by: Julien Jerphanion <[email protected]>
Signed-off-by: Julien Jerphanion <[email protected]> Co-authored-by: Klaim <[email protected]>
d5ce5ca to
056ba37
Compare
Description
Fix #1881.
Fix #4009.
Type of Change
Checklist
pre-commit run --alllocally in the source folder and confirmed that there are no linter errors.