Skip to content

Conversation

@jjerphan
Copy link
Member

Description

Fix #1881.
Fix #4009.

Type of Change

  • Bugfix
  • Feature / enhancement
  • CI / Documentation
  • Maintenance

Checklist

  • My code follows the general style and conventions of the codebase, ensuring consistency
  • I have performed a self-review of my code
  • I have commented my code, particularly in hard-to-understand areas
  • My changes generate no new warnings
  • I have run pre-commit run --all locally in the source folder and confirmed that there are no linter errors.
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing tests pass locally with my changes

@github-actions github-actions bot added the release::enhancements For enhancements PRs or implementing features label Nov 27, 2025
@codecov
Copy link

codecov bot commented Nov 27, 2025

Codecov Report

❌ Patch coverage is 0% with 116 lines in your changes missing coverage. Please review.
✅ Project coverage is 63.30%. Comparing base (4a43769) to head (056ba37).
⚠️ Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
libmamba/src/api/env.cpp 0.00% 54 Missing ⚠️
micromamba/src/env.cpp 0.00% 46 Missing ⚠️
libmamba/src/api/install.cpp 0.00% 16 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #4106      +/-   ##
==========================================
- Coverage   63.48%   63.30%   -0.18%     
==========================================
  Files         315      315              
  Lines       38644    38751     +107     
  Branches     2969     2980      +11     
==========================================
  Hits        24532    24532              
- Misses      14043    14150     +107     
  Partials       69       69              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Copy link
Member Author

@jjerphan jjerphan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Comments for reviewers.

@jjerphan jjerphan marked this pull request as ready for review November 27, 2025 10:45
Copy link
Member

@Klaim Klaim left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, all my remarks are nitpicks, nothing important 👍🏽

@jjerphan jjerphan force-pushed the feat/env-variables branch 2 times, most recently from f2ab756 to d5ce5ca Compare December 2, 2025 15:10
jjerphan and others added 3 commits December 2, 2025 16:16
Signed-off-by: Julien Jerphanion <[email protected]>

Co-authored-by: Klaim <[email protected]>
@jjerphan jjerphan merged commit a25529e into mamba-org:main Dec 2, 2025
35 of 37 checks passed
@jjerphan jjerphan deleted the feat/env-variables branch December 2, 2025 16:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

release::enhancements For enhancements PRs or implementing features

Projects

None yet

Development

Successfully merging this pull request may close these issues.

env config vars not respected between conda and mamba How to set environment variables for a micromamba environment?

3 participants