feat: Sharded Repodata Support for repoquery#4226
Open
jjerphan wants to merge 3 commits intomamba-org:mainfrom
Open
feat: Sharded Repodata Support for repoquery#4226jjerphan wants to merge 3 commits intomamba-org:mainfrom
repoquery#4226jjerphan wants to merge 3 commits intomamba-org:mainfrom
Conversation
Signed-off-by: Julien Jerphanion <git@jjerphan.xyz>
github-actions
bot
added
the
release::enhancements
Codecov Report❌ Patch coverage is Additional details and impacted files@@ Coverage Diff @@
## main #4226 +/- ##
==========================================
+ Coverage 52.73% 52.75% +0.02%
==========================================
Files 240 240
Lines 29526 29551 +25
Branches 3154 3159 +5
==========================================
+ Hits 15570 15591 +21
- Misses 13953 13957 +4
Partials 3 3 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Signed-off-by: Julien Jerphanion <git@jjerphan.xyz>
Signed-off-by: Julien Jerphanion <git@jjerphan.xyz>
jjerphan
commented
Apr 9, 2026
Comment on lines
+264
to
+267
| if platform.system() == "Windows": | ||
| assert package_info["python_site_packages_path"] == "Lib/site-packages" | ||
| else: | ||
| assert package_info["python_site_packages_path"] == "lib/python3.13t/site-packages" |
Member
Author
There was a problem hiding this comment.
Is this correct? This is based on:
mamba/libmamba/src/core/transaction.cpp
Lines 132 to 138 in f7d6d8e
which is based on what I have observed.
| if (!parsed || parsed->name().is_free() || !parsed->name().is_exact()) | ||
| { | ||
| return {}; | ||
| } |
Member
There was a problem hiding this comment.
Maybe it would be better to log the failing parsing and continue?
| if (name.empty()) | ||
| { | ||
| return {}; | ||
| } |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Type of Change
Checklist
pre-commit run --alllocally in the source folder and confirmed that there are no linter errors.