fix: manualChunks deletion / override#137
Open
bvandercar-vt wants to merge 13 commits intomammadataei:mainfrom
Open
fix: manualChunks deletion / override#137bvandercar-vt wants to merge 13 commits intomammadataei:mainfrom
bvandercar-vt wants to merge 13 commits intomammadataei:mainfrom
Conversation
bvandercar-vt
force-pushed
the
fix/manualChunks-deletion
branch
from
09b4041 to
c7ae875
Compare
Contributor
Author
|
@mammadataei I totally redid this PR, much simpler now. Ready for review! |
TobiTenno
approved these changes
Mar 23, 2026
|
Any update on this PR? |
|
Any updates on this? For now we removed the dep and fixed it ourself by adding a custom viteProcessor. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes the issue brought up by this PR: #136 but provides a fix that works for both
rollupandrolldown. Have tried too many times to find the right value to override formanualChunks... let's just delete it.