make update_docu_links independet on the location it is called from#5583
make update_docu_links independet on the location it is called from#55835ila5 wants to merge 1 commit into
Conversation
|
Thanks for making the script independent of the current working directory. The general approach of resolving paths relative to file looks good. There is one cross-platform regression compared with the previous implementation: @Property The previous implementation constructed documentation links explicitly with /, for example: filename = f"/doc/source/{file}.md" With the new implementation, str(Path(...)) uses the platform-specific path separator. On Windows this can generate links such as: /doc\source\example.md Since this value is used for Markdown links and GitHub documentation URLs, it should always use POSIX separators: @Property Apart from this cross-platform issue, the path refactoring looks good. |
|
but maybe we should wait until the BaseSource PR is merged. |
This can wait until #5577 is through