Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow metrics to be registered twice #1816

Merged
merged 1 commit into from
Sep 6, 2024
Merged

Conversation

poodlewars
Copy link
Collaborator

Remove the reconfigure flag, it's never set to true in practice and it isn't implemented correctly.

Allow metrics to be re-registered, it's too annoying in the replication tests otherwise since the PrometheusInstance is static state.

@poodlewars poodlewars merged commit 56e88c1 into master Sep 6, 2024
116 checks passed
@poodlewars poodlewars deleted the allow-metrics-rereg branch September 6, 2024 08:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants