Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix handling of empty DF in pandas 1.0 #2010

Merged
merged 1 commit into from
Nov 19, 2024
Merged

fix handling of empty DF in pandas 1.0 #2010

merged 1 commit into from
Nov 19, 2024

Conversation

grusev
Copy link
Collaborator

@grusev grusev commented Nov 19, 2024

Reference Issues/PRs

Fix test failure for new merged readd_batch(), due to problem in Pandas 1.x when arctic returns empty DF

What does this implement or fix?

Any other comments?

Checklist

Checklist for code changes...
  • Have you updated the relevant docstrings, documentation and copyright notice?
  • Is this contribution tested against all ArcticDB's features?
  • Do all exceptions introduced raise appropriate error messages?
  • Are API changes highlighted in the PR description?
  • Is the PR labelled as enhancement or bug so it appears in autogenerated release notes?

@willdealtry willdealtry changed the title fix hanfling of empty DF in pandas 1.0 fix handling of empty DF in pandas 1.0 Nov 19, 2024
@grusev grusev merged commit 0b96185 into master Nov 19, 2024
108 of 115 checks passed
@grusev grusev deleted the fix_tests_read_batch branch November 19, 2024 13:44
phoebusm pushed a commit that referenced this pull request Nov 27, 2024
#### Reference Issues/PRs
<!--Example: Fixes #1234. See also #3456.-->
Fix test failure for new merged readd_batch(), due to problem in Pandas
1.x when arctic returns empty DF


#### What does this implement or fix?

#### Any other comments?

#### Checklist

<details>
  <summary>
   Checklist for code changes...
  </summary>
 
- [ ] Have you updated the relevant docstrings, documentation and
copyright notice?
- [ ] Is this contribution tested against [all ArcticDB's
features](../docs/mkdocs/docs/technical/contributing.md)?
- [ ] Do all exceptions introduced raise appropriate [error
messages](https://docs.arcticdb.io/error_messages/)?
 - [ ] Are API changes highlighted in the PR description?
- [ ] Is the PR labelled as enhancement or bug so it appears in
autogenerated release notes?
</details>

<!--
Thanks for contributing a Pull Request to ArcticDB! Please ensure you
have taken a look at:
- ArcticDB's Code of Conduct:
https://github.com/man-group/ArcticDB/blob/master/CODE_OF_CONDUCT.md
- ArcticDB's Contribution Licensing:
https://github.com/man-group/ArcticDB/blob/master/docs/mkdocs/docs/technical/contributing.md#contribution-licensing
-->

Co-authored-by: Georgi Rusev <Georgi Rusev>
grusev added a commit that referenced this pull request Dec 3, 2024
#### Reference Issues/PRs
<!--Example: Fixes #1234. See also #3456.-->
Fix test failure for new merged readd_batch(), due to problem in Pandas
1.x when arctic returns empty DF


#### What does this implement or fix?

#### Any other comments?

#### Checklist

<details>
  <summary>
   Checklist for code changes...
  </summary>
 
- [ ] Have you updated the relevant docstrings, documentation and
copyright notice?
- [ ] Is this contribution tested against [all ArcticDB's
features](../docs/mkdocs/docs/technical/contributing.md)?
- [ ] Do all exceptions introduced raise appropriate [error
messages](https://docs.arcticdb.io/error_messages/)?
 - [ ] Are API changes highlighted in the PR description?
- [ ] Is the PR labelled as enhancement or bug so it appears in
autogenerated release notes?
</details>

<!--
Thanks for contributing a Pull Request to ArcticDB! Please ensure you
have taken a look at:
- ArcticDB's Code of Conduct:
https://github.com/man-group/ArcticDB/blob/master/CODE_OF_CONDUCT.md
- ArcticDB's Contribution Licensing:
https://github.com/man-group/ArcticDB/blob/master/docs/mkdocs/docs/technical/contributing.md#contribution-licensing
-->

Co-authored-by: Georgi Rusev <Georgi Rusev>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants