Fix convert_int_to_float in compact_incomplete V1 library API method #2235
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reference Issues/PRs
What does this implement or fix?
This fixes the behavior of
convert_int_to_float
exposed via the V1 Library API'scompact_incomplete
method.Convert int to float will change the type of all integer columns (both signed and unsigned) to float64. In contrast to dynamic schema conversion this will static cast the values of all segments to float64 prior writing. This functionality was broken when we made the stricter type checks for staged segments.
Additional bugfix was added for dynamic schema. Dynamic schema has a different code path as it calls merge descriptors when it collects all incomplete segments thus the option was not properly applied even in arcticc.
There are two main points:
Any other comments?
Checklist
Checklist for code changes...