Fix test_chunks_the_same flakiness #2239
Open
+14
−8
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
poodlewars
added
flaky test
poodlewars
changed the title
poodlewars
changed the title
poodlewars
force-pushed
the
test-chunks-the-same-flakiness
branch
from
f432f3d to
5382581
Compare
This would fail sometimes on Windows / Mac because the clocks used there are less precise and the two [1000, 1001] segments would collide on exactly the same key with LMDB. I just change the test so their content hashes would be different. The test was written to cover an issue with identical index ranges, so it still meets its original purpose. This just changes the tests so that their content hashes differ. Theoretically, this could be a real problem that comes up, and we ought to somehow retry when there is a key clash. But that seems very improbable outside of unit testing, so we leave it as is for now.
poodlewars
force-pushed
the
test-chunks-the-same-flakiness
branch
from
5382581 to
8e416ab
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix for flaky test test_chunks_the_same
This would fail sometimes on Windows / Mac because the clocks used there are less precise and the two [1000, 1001] segments would collide on exactly the same key with LMDB. I just change the test so their content hashes would be different. The test was written to cover an issue with identical index ranges, so it still meets its original purpose.
This just changes the tests so that their content hashes differ. Theoretically, this could be a real problem that comes up, and we ought to somehow retry when there is a key clash. But that seems very improbable outside of unit testing, so we leave it as is for now.